linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Sumit Garg <sumit.garg@linaro.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	Sebastian Duda <sebastian.duda@fau.de>,
	Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
Date: Thu, 05 Mar 2020 12:46:10 -0800	[thread overview]
Message-ID: <1583441170.3927.37.camel@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003052132540.5431@felia>

On Thu, 2020-03-05 at 21:34 +0100, Lukas Bulwahn wrote:
> 
> On Thu, 5 Mar 2020, Jarkko Sakkinen wrote:
> 
> > On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> > > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys
> > > subsystem")
> > > renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> > > trusted.c
> > > to trusted-keys/trusted_tpm1.c in security/keys/.
> > > 
> > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > 
> > >   warning: no file matches F: security/keys/trusted.c
> > >   warning: no file matches F: include/keys/trusted.h
> > > 
> > > Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> > > 
> > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Sumit, please ack.
> > > Jarkko, please pick this patch.
> > 
> > I'll pick it when it is done. I acknowledge the regression but I
> > see no reason for rushing as this does not break any systems in
> > the wild.
> > 
> 
> Agree. No need to rush this. I sent out a v3, and I hope to get
> Sumit's ACK and then you can pick it for the next merge window.

From a process point of view, I don't quite understand this.  You're
altering an entry in the MAINTAINERS file which belongs to the three
maintainers of trusted keys, you only need our ack to do that, which
picking up via the trusted key tree will substitute for.  It would be
useful to have Sumit review this because he moved the files and there
may be something we missed, but a reviewed-by: is a nice to have and
not a block on the process.

James


  reply	other threads:[~2020-03-05 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 16:03 [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
2020-03-04 16:12 ` James Bottomley
2020-03-04 21:15   ` Lukas Bulwahn
2020-03-05 11:25 ` Jarkko Sakkinen
2020-03-05 20:34   ` Lukas Bulwahn
2020-03-05 20:46     ` James Bottomley [this message]
2020-03-05 21:10       ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1583441170.3927.37.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=sebastian.duda@fau.de \
    --cc=sumit.garg@linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).