linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
	Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Subject: Re: [PATCH v7] ima-evm-utils: Add some tests for evmctl
Date: Mon, 23 Mar 2020 10:23:42 -0400	[thread overview]
Message-ID: <1584973422.5188.247.camel@linux.ibm.com> (raw)

Hi Vitaly,

I really appreciate your creating this set of tests!  However, when
you first posted this patch, I asked you to break it up into more
manageable pieces to review.  I understand this isn't the Linux
kernel, "just" some tests, but there is good reason that the Linux
kernel development requires large patches be broken up into more
manageable small, logical changes.

I've recently asked a few people to help review this patch.  I
understand that it is a lot of work to break this patch up into
smaller patches, but it will simplify review.

If I was to break up this patch, I would start by making the test
driver and each of the tests a separate patch.  The test driver patch
description should reference the GNU documentation, with an
explanation as to why a custom driver is preferred[1].

thanks,

Mimi

[1] https://www.gnu.org/software/automake/manual/html_node/Generalitie
s-about-Testing.html#Generalities-about-Testing


             reply	other threads:[~2020-03-23 14:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 14:23 Mimi Zohar [this message]
2020-03-23 16:17 ` [PATCH v7] ima-evm-utils: Add some tests for evmctl Vitaly Chikunov
  -- strict thread matches above, loose matches on Subject: below --
2019-08-17 23:33 Vitaly Chikunov
2020-03-19 15:18 ` Lakshmi Ramasubramanian
2020-03-19 15:49   ` Vitaly Chikunov
2020-03-19 16:36     ` Lakshmi Ramasubramanian
2020-03-19 21:57       ` Lakshmi Ramasubramanian
2020-03-22 22:10         ` Vitaly Chikunov
2020-03-23 15:48           ` Lakshmi Ramasubramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1584973422.5188.247.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=vt@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).