From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD2BC433E0 for ; Wed, 13 May 2020 19:39:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5575A206E5 for ; Wed, 13 May 2020 19:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589398756; bh=KXxqBrzLeeAqHk4gtdn0I0ZYxOj9nDjdnEZkDmE/AD0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=FsRPF+43FvWk+oNd+/+McEJBoZBt69x9cI1uqhdNojVGLsX8P16KbP3P3IqeIjJ0u Q/CAPmgbS6dU4rFgaxWIoX40ZRgG0Q4FJD6d1UoaUKUT5Xk/UfSoh88JKd2PL8jJrC 4+gCpCOEqaG2s5CEu8ZEErkLn5djyQtl34WknxcQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390473AbgEMTjL (ORCPT ); Wed, 13 May 2020 15:39:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:55264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732218AbgEMTjL (ORCPT ); Wed, 13 May 2020 15:39:11 -0400 Received: from localhost.localdomain (pool-96-246-152-186.nycmny.fios.verizon.net [96.246.152.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90A7620659; Wed, 13 May 2020 19:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589398751; bh=KXxqBrzLeeAqHk4gtdn0I0ZYxOj9nDjdnEZkDmE/AD0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=icAvLYRsMmmlKalnFgVitIB6YgqA5lAMu+YhIRLXxIIiq3BVLuq9N95zqswodsRBB 1iKYOsmVyCZO60BoDYbCKNJEIhejePOe3LB4KNE1PQagmFEiJF8x/qSDynheLtg1Pf 3SUpbR9S+ZBoeJkotoGwwocdmG39FBSjNE2dKy/k= Message-ID: <1589398747.5098.178.camel@kernel.org> Subject: Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support From: Mimi Zohar To: Scott Branden , Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann Cc: "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-security-module , linux-integrity Date: Wed, 13 May 2020 15:39:07 -0400 In-Reply-To: References: <20200508002739.19360-1-scott.branden@broadcom.com> <20200508002739.19360-2-scott.branden@broadcom.com> <1589395153.5098.158.camel@kernel.org> <0e6b5f65-8c61-b02e-7d35-b4ae52aebcf3@broadcom.com> <1589396593.5098.166.camel@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, 2020-05-13 at 12:18 -0700, Scott Branden wrote: > On 2020-05-13 12:03 p.m., Mimi Zohar wrote: > > On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: > Even if the kernel successfully verified the firmware file signature it > would just be wasting its time.  The kernel in these use cases is not always > trusted.  The device needs to authenticate the firmware image itself. There are also environments where the kernel is trusted and limits the firmware being provided to the device to one which they signed. > > The device firmware is being downloaded piecemeal from somewhere and > > won't be measured? > It doesn't need to be measured for current driver needs. Sure the device doesn't need the kernel measuring the firmware, but hardened environments do measure firmware. > If someone has such need the infrastructure could be added to the kernel > at a later date.  Existing functionality is not broken in any way by > this patch series. Wow!  You're saying that your patch set takes precedence over the existing expectations and can break them. Mimi