From: Mimi Zohar <zohar@linux.ibm.com>
To: Roberto Sassu <roberto.sassu@huawei.com>, torvalds@linux-foundation.org
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
silviu.vlasceanu@huawei.com, stable@vger.kernel.org,
Jerry Snitselaar <jsnitsel@redhat.com>,
"Bruno E. O. Meneguele" <bmeneg@redhat.com>
Subject: Re: [PATCH] ima: Remove __init annotation from ima_pcrread()
Date: Mon, 08 Jun 2020 09:14:58 -0400 [thread overview]
Message-ID: <1591622098.4638.67.camel@linux.ibm.com> (raw)
In-Reply-To: <20200607210029.30601-1-roberto.sassu@huawei.com>
Hi Roberto,
On Sun, 2020-06-07 at 23:00 +0200, Roberto Sassu wrote:
> Commit 6cc7c266e5b4 ("ima: Call ima_calc_boot_aggregate() in
> ima_eventdigest_init()") added a call to ima_calc_boot_aggregate() so that
> the digest can be recalculated for the boot_aggregate measurement entry if
> the 'd' template field has been requested. For the 'd' field, only SHA1 and
> MD5 digests are accepted.
>
> Given that ima_eventdigest_init() does not have the __init annotation, all
> functions called should not have it. This patch removes __init from
> ima_pcrread().
>
> Cc: stable@vger.kernel.org
> Fixes: 6cc7c266e5b4 ("ima: Call ima_calc_boot_aggregate() in ima_eventdigest_init()")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Thank you for fixing this so quickly! Jerry, Bruno, thank you for the
Reviews. This patch is in Linus' tree as: 8b8c704d913b ("ima: Remove
__init annotation from ima_pcrread()".
Mimi
prev parent reply other threads:[~2020-06-08 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 21:00 [PATCH] ima: Remove __init annotation from ima_pcrread() Roberto Sassu
2020-06-07 23:11 ` Jerry Snitselaar
2020-06-08 13:00 ` Bruno Meneguele
2020-06-08 13:14 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591622098.4638.67.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bmeneg@redhat.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).