From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Steve Grubb <sgrubb@redhat.com>
Cc: linux-audit@redhat.com, paul@paul-moore.com,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] IMA: Add audit log for failure conditions
Date: Tue, 09 Jun 2020 13:14:56 -0400 [thread overview]
Message-ID: <1591722896.5567.31.camel@linux.ibm.com> (raw)
In-Reply-To: <518a51b7-6c8d-f55f-c73a-b15abae8e0af@linux.microsoft.com>
On Tue, 2020-06-09 at 10:00 -0700, Lakshmi Ramasubramanian wrote:
> On 6/9/20 9:43 AM, Steve Grubb wrote:
>
> >> The number in parenthesis is the error code (such as ENOMEM, EINVAL,
> >> etc.) IMA uses this format for reporting TPM errors in one of the audit
> >> messages (In ima_add_template_entry()). I followed the same pattern.
> >>
> >> Would it be better if the value for "cause" is formatted as
> >>
> >> cause=hashing_error_-22
> >>
> >> cause=alloc_entry_-12
> >
> > Neither fit the name=value style that all other events follow. What would fit
> > the style is something like this:
> >
> > cause=hashing_error errno=-22
> >
> > cause=alloc_entry errno=-12
> >
> > Would this be OK? Also, errno is only to illustrate. You can name it
> > something else as long as there are no use case collisions with our
> > dictionary of field names.
> >
> > https://github.com/linux-audit/audit-documentation/blob/master/specs/fields/
> > field-dictionary.csv
>
> I am fine with this.
>
> "errno" is currently not listed in the dictionary of audit message field
> names (Thanks for the pointer to this one Steve)
>
> Mimi - please let me know if you have any concerns with adding the
> "result" code in "errno" field in integrity_audit_msg().
>
> Sample message:
>
> [ 8.051937] audit: type=1804 audit(1591633422.365:8): pid=1 uid=0
> auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0
> op=measuring_keys cause=hashing_error errno=-22 comm="systemd"
> name=".builtin_trusted_keys" res=0
Yes, that's fine.
Mimi
next prev parent reply other threads:[~2020-06-09 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 21:53 [PATCH v3] IMA: Add audit log for failure conditions Lakshmi Ramasubramanian
2020-06-09 12:54 ` Richard Guy Briggs
2020-06-09 15:40 ` Steve Grubb
2020-06-09 15:58 ` Lakshmi Ramasubramanian
2020-06-09 16:43 ` Steve Grubb
2020-06-09 17:00 ` Lakshmi Ramasubramanian
2020-06-09 17:14 ` Mimi Zohar [this message]
2020-06-09 17:15 ` Richard Guy Briggs
2020-06-09 17:33 ` Mimi Zohar
2020-06-09 17:35 ` Steve Grubb
2020-06-09 18:03 ` Lakshmi Ramasubramanian
2020-06-09 17:04 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591722896.5567.31.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).