From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
sgrubb@redhat.com, paul@paul-moore.com
Cc: rgb@redhat.com, linux-integrity@vger.kernel.org,
linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] IMA: Add audit log for failure conditions
Date: Tue, 23 Jun 2020 15:58:15 -0400 [thread overview]
Message-ID: <1592942295.5389.9.camel@linux.ibm.com> (raw)
In-Reply-To: <20200618211012.2823-2-nramas@linux.microsoft.com>
On Thu, 2020-06-18 at 14:10 -0700, Lakshmi Ramasubramanian wrote:
> process_buffer_measurement() and ima_alloc_key_entry() functions need to
> log an audit message for auditing integrity measurement failures.
>
> Add audit message in these two functions. Remove "pr_devel" log message
> in process_buffer_measurement().
>
> Sample audit messages:
>
> [ 6.303048] audit: type=1804 audit(1592506281.627:2): pid=1 uid=0
> auid=4294967295 ses=4294967295 subj=kernel op=measuring_key
> cause=ENOMEM comm="swapper/0" name=".builtin_trusted_keys" res=0
> errno=-12
My only concern is that auditing -ENOMEM will put additional memory
pressure on the system. I'm not sure if this is a concern and, if so,
how it should be handled.
>
> [ 8.019432] audit: type=1804 audit(1592506283.344:10): pid=1
> uid=0 auid=4294967295 ses=4294967295
> subj=system_u:system_r:init_t:s0 op=measuring_kexec_cmdline
> cause=hashing_error comm="systemd" name="kexec-cmdline" res=0
> errno=-22
>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
next prev parent reply other threads:[~2020-06-23 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 21:10 [PATCH v3 1/2] integrity: Add errno field in audit message Lakshmi Ramasubramanian
2020-06-18 21:10 ` [PATCH v3 2/2] IMA: Add audit log for failure conditions Lakshmi Ramasubramanian
2020-06-23 19:58 ` Mimi Zohar [this message]
2020-06-24 17:25 ` Lakshmi Ramasubramanian
2020-06-25 19:14 ` Paul Moore
2020-06-29 16:57 ` Mimi Zohar
2020-06-22 22:27 ` [PATCH v3 1/2] integrity: Add errno field in audit message Mimi Zohar
2020-06-24 0:07 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592942295.5389.9.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).