From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>
Subject: Re: [PATCH v3 1/1] tpm: add sysfs exports for all banks of PCR registers
Date: Sun, 26 Jul 2020 20:25:39 -0700 [thread overview]
Message-ID: <1595820339.32688.26.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200724065745.GB1871046@linux.intel.com>
On Fri, 2020-07-24 at 09:57 +0300, Jarkko Sakkinen wrote:
> On Wed, Jul 22, 2020 at 08:57:39AM -0700, James Bottomley wrote:
> > use macro magic to create sysfs per hash groups with 24 PCR files
> > in
>
> 'Use'
>
> Please, just say what the patch does in plain English and dust the
> magic away.
The reason for the macro magic comment is that there are 3 checkpatch
errors and one warning from this, all spurious, because checkpatch
doesn't understand the syntax of macros that create macros.
> > them one for each possible agile hash of the TPM. The files are
> ~~
>
> I'd prefer a single space.
It's still listed in the style guides as best practice for monospaced
fonts, but at this point I've lost the will to care about it.
> > plugged in to a read function which is TPM version agnostic, so
> > this works also for TPM 1.2 although the hash is only sha1 in that
> > case. For every hash the TPM supports, a group named pcr-<hash> is
> > created and each of the PCR read files placed under it.
>
> Yeah, the commit message is missing the statement what it does and
> goes straight away rationalizing "macro magic".
OK so how about
---
Create sysfs per hash groups with 24 PCR files in them one group, named
pcr-<hash>, for each agile hash of the TPM. The files are plugged in
to a PCR read function which is TPM version agnostic, so this works
also for TPM 1.2 although the hash is only sha1 in that case.
Note: the macros used to create the hashes emit spurious checkpatch
warnings. Do not try to "fix" them as checkpatch recommends otherwise
they'll break.
---
James
next prev parent reply other threads:[~2020-07-27 3:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 15:57 [PATCH v3 0/1] add sysfs exports for TPM 2 PCR registers James Bottomley
2020-07-22 15:57 ` [PATCH v3 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-07-24 6:57 ` Jarkko Sakkinen
2020-07-27 3:25 ` James Bottomley [this message]
2020-08-04 11:35 ` Mimi Zohar
2020-08-18 5:38 ` Jarkko Sakkinen
2020-07-27 15:08 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595820339.32688.26.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).