From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF01C433DF for ; Mon, 27 Jul 2020 14:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5175920714 for ; Mon, 27 Jul 2020 14:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595860927; bh=0XkNZGMfPjvvPJ4vDl6luNql4PL5ypWVUV/Rm+mizsE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=zMRAiGAxWPCnmIVyIFUvTZwwBC7o0eqn0F5+6wmyqqtj7RJyp3xDonADTdwy8wrDS C9Yr+U1SjhiF7/AYBiaI8tTzZpIHdCNu9RqJ3iyVUx4zHXmbIMSu7G7h6HXNFCPvDd 7PguEKjiCm/lT1EaMtE8LziP4LJ+IM6piB+fniB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733111AbgG0OmC (ORCPT ); Mon, 27 Jul 2020 10:42:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:40810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbgG0Olw (ORCPT ); Mon, 27 Jul 2020 10:41:52 -0400 Received: from localhost.localdomain (pool-96-246-152-186.nycmny.fios.verizon.net [96.246.152.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FB70208E4; Mon, 27 Jul 2020 14:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595860912; bh=0XkNZGMfPjvvPJ4vDl6luNql4PL5ypWVUV/Rm+mizsE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jpg/EmyQDv9FT7kOivKMX8wFhGU4sFTB2CH3Fh4EZTjsJsvFBn7m7pngU0GoPyW+3 39SrDAlP4E+C6K+8ut68HKiV0e/CnGbZncwAxpQzwd+vVR2JJIvbvJk/g27MBtu9Ku qK+mrjkQ3I6tKw3z/+lX1qAQaaqCDbWrPRjvxXS0= Message-ID: <1595860910.4841.118.camel@kernel.org> Subject: Re: [PATCH v3 06/19] fs/kernel_read_file: Split into separate include file From: Mimi Zohar To: Kees Cook , Greg Kroah-Hartman Cc: Scott Branden , Christoph Hellwig , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2020 10:41:50 -0400 In-Reply-To: <20200724213640.389191-7-keescook@chromium.org> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-7-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > From: Scott Branden > > Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h > include file. That header gets pulled in just about everywhere > and doesn't really need functions not related to the general fs interface. > > Suggested-by: Christoph Hellwig > Signed-off-by: Scott Branden > Reviewed-by: Christoph Hellwig > Acked-by: Greg Kroah-Hartman > Link: https://lore.kernel.org/r/20200706232309.12010-2-scott.branden@broadcom.com > Signed-off-by: Kees Cook Reviewed-by: Mimi Zohar