From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47504C433F2 for ; Mon, 27 Jul 2020 16:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CA2D2078E for ; Mon, 27 Jul 2020 16:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595867380; bh=8oCB6uea+aVDOj/Yx59qQSnN7cBU25mvgxQKlD5dQsQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=WnXf0nEDOthtX4PAAWkkguirJR0FyxpzDH5kC9MpfSMhsE+l81GzeYh7Sie89a2Ji 6fuZUl5OVcF2Z2HNtH4hnf7wqcEkXsGH5Fr75wl/2L7Kvr3DwUPKurDXK0MXHp8JER v0fGZebU3Pgp4ZRlTnILhBQvTY3U0z15nNxgxXgE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730760AbgG0Q3g (ORCPT ); Mon, 27 Jul 2020 12:29:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:58008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgG0Q3g (ORCPT ); Mon, 27 Jul 2020 12:29:36 -0400 Received: from localhost.localdomain (pool-96-246-152-186.nycmny.fios.verizon.net [96.246.152.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3311C20719; Mon, 27 Jul 2020 16:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595867376; bh=8oCB6uea+aVDOj/Yx59qQSnN7cBU25mvgxQKlD5dQsQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=J7PC4nMUIbBazsfj45I5T2O5RZXhlruY1Jd9CA0AJI5vjSA1UL5rdPqK1C7d/pPCV sLTGX0tw+4gnCZQY1RVslJDjjsiq48PwpQFy+rTHxjKdWcEnP6I7CAB4G6haKHwDTC YztTFKyEh1+gVHD8M0jLZgoi7JNzq9DWCvOKvMbE= Message-ID: <1595867374.4841.135.camel@kernel.org> Subject: Re: [PATCH v3 09/19] fs/kernel_read_file: Switch buffer size arg to size_t From: Mimi Zohar To: Kees Cook , Greg Kroah-Hartman Cc: Scott Branden , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2020 12:29:34 -0400 In-Reply-To: <20200724213640.389191-10-keescook@chromium.org> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-10-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > In preparation for further refactoring of kernel_read_file*(), rename > the "max_size" argument to the more accurate "buf_size", and correct > its type to size_t. Add kerndoc to explain the specifics of how the > arguments will be used. Note that with buf_size now size_t, it can no > longer be negative (and was never called with a negative value). Adjust > callers to use it as a "maximum size" when *buf is NULL. > > Acked-by: Scott Branden > Signed-off-by: Kees Cook Reviewed-by: Mimi Zohar