From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E5AC169C4 for ; Tue, 29 Jan 2019 12:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A7CF2083B for ; Tue, 29 Jan 2019 12:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfA2MbO (ORCPT ); Tue, 29 Jan 2019 07:31:14 -0500 Received: from mga02.intel.com ([134.134.136.20]:6074 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbfA2MbO (ORCPT ); Tue, 29 Jan 2019 07:31:14 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 04:31:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="113579062" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.127]) by orsmga008.jf.intel.com with ESMTP; 29 Jan 2019 04:31:11 -0800 Date: Tue, 29 Jan 2019 14:31:11 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Tomas Winkler , Tadeusz Struk , Stefan Berger , Nayna Jain Subject: Re: [PATCH v10 00/17] Remove nested TPM operations Message-ID: <20190129123111.GA12883@linux.intel.com> References: <20190116212342.24524-1-jarkko.sakkinen@linux.intel.com> <20190123182057.GA24212@linux.intel.com> <37e53df5-4a25-fce2-d3bf-016669d0a383@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37e53df5-4a25-fce2-d3bf-016669d0a383@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Jan 23, 2019 at 01:53:44PM -0500, Stefan Berger wrote: > On 1/23/19 1:20 PM, Jarkko Sakkinen wrote: > > On Wed, Jan 16, 2019 at 11:23:25PM +0200, Jarkko Sakkinen wrote: > > > Make the changes necessary to detach TPM space code and TPM activation > > > code out of the tpm_transmit() flow because of both of these can cause > > > nested tpm_transmit() calls. The nesteds calls make the whole flow hard > > > to maintain, and thus, it is better to just fix things now before this > > > turns into a bigger mess. > > Any reasons not to merge this soon? > > I suppose v10 hasn't changed anything signinficat. So, not from my > perspective. Were you waiting for more Reviewed-by's? Yeah, for example TPM space touching changes would be good to peer check with James. I could have easily forgotten some implementation detail, and it has been very stable piece off code, so don't want to break it. Guess won't yet try to put this v5.1. /Jarkko