From: kbuild test robot <lkp@intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: kbuild-all@01.org, jarkko.sakkinen@linux.intel.com,
zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
matthewgarrett@google.com, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v9 4/6] tpm: move tpm_chip definition to include/linux/tpm.h
Date: Mon, 4 Feb 2019 16:58:21 +0800 [thread overview]
Message-ID: <201902041630.P1UzejFY%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190201100641.26936-5-roberto.sassu@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 3528 bytes --]
Hi Roberto,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jss-tpmdd/next]
[also build test WARNING on next-20190204]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Roberto-Sassu/tpm-retrieve-digest-size-of-unknown-algorithms-from-TPM/20190204-161932
base: git://git.infradead.org/users/jjs/linux-tpmdd next
config: i386-randconfig-x006-201905 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
>> drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
#define TPM_RETRY 5
In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
#define TPM_RETRY 50 /* 5 seconds */
--
In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
>> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 2048
In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
vim +/TPM_RETRY +45 drivers/char/tpm/tpm_i2c_nuvoton.c
4c336e4b Jason Gunthorpe 2013-10-06 36
4c336e4b Jason Gunthorpe 2013-10-06 37 /* I2C interface offsets */
4c336e4b Jason Gunthorpe 2013-10-06 38 #define TPM_STS 0x00
4c336e4b Jason Gunthorpe 2013-10-06 39 #define TPM_BURST_COUNT 0x01
4c336e4b Jason Gunthorpe 2013-10-06 40 #define TPM_DATA_FIFO_W 0x20
4c336e4b Jason Gunthorpe 2013-10-06 41 #define TPM_DATA_FIFO_R 0x40
4c336e4b Jason Gunthorpe 2013-10-06 42 #define TPM_VID_DID_RID 0x60
4c336e4b Jason Gunthorpe 2013-10-06 43 /* TPM command header size */
4c336e4b Jason Gunthorpe 2013-10-06 44 #define TPM_HEADER_SIZE 10
4c336e4b Jason Gunthorpe 2013-10-06 @45 #define TPM_RETRY 5
4c336e4b Jason Gunthorpe 2013-10-06 46 /*
4c336e4b Jason Gunthorpe 2013-10-06 47 * I2C bus device maximum buffer size w/o counting I2C address or command
4c336e4b Jason Gunthorpe 2013-10-06 48 * i.e. max size required for I2C write is 34 = addr, command, 32 bytes data
4c336e4b Jason Gunthorpe 2013-10-06 49 */
4c336e4b Jason Gunthorpe 2013-10-06 50 #define TPM_I2C_MAX_BUF_SIZE 32
4c336e4b Jason Gunthorpe 2013-10-06 51 #define TPM_I2C_RETRY_COUNT 32
a233a028 Nayna Jain 2017-03-10 52 #define TPM_I2C_BUS_DELAY 1000 /* usec */
a233a028 Nayna Jain 2017-03-10 53 #define TPM_I2C_RETRY_DELAY_SHORT (2 * 1000) /* usec */
a233a028 Nayna Jain 2017-03-10 54 #define TPM_I2C_RETRY_DELAY_LONG (10 * 1000) /* usec */
a233a028 Nayna Jain 2017-03-10 55 #define TPM_I2C_DELAY_RANGE 300 /* usec */
4c336e4b Jason Gunthorpe 2013-10-06 56
:::::: The code at line 45 was first introduced by commit
:::::: 4c336e4b1556f4b722ba597bc6e3df786968a600 tpm: Add support for the Nuvoton NPCT501 I2C TPM
:::::: TO: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
:::::: CC: Peter Huewe <peterhuewe@gmx.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25076 bytes --]
next prev parent reply other threads:[~2019-02-04 8:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 10:06 [PATCH v9 0/6] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2019-02-01 10:06 ` [PATCH v9 1/6] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2019-02-01 13:34 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 2/6] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2019-02-01 13:36 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 3/6] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2019-02-01 10:06 ` [PATCH v9 4/6] tpm: move tpm_chip definition to include/linux/tpm.h Roberto Sassu
2019-02-01 13:38 ` Jarkko Sakkinen
2019-02-04 8:58 ` kbuild test robot [this message]
2019-02-01 10:06 ` [PATCH v9 5/6] KEYS: trusted: explicitly use tpm_chip structure from tpm_default_chip() Roberto Sassu
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend() Roberto Sassu
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 13:41 ` Jarkko Sakkinen
2019-02-01 14:33 ` Mimi Zohar
2019-02-01 17:33 ` Jarkko Sakkinen
2019-02-01 17:42 ` Jarkko Sakkinen
2019-02-01 19:15 ` Mimi Zohar
2019-02-04 9:14 ` Roberto Sassu
2019-02-04 12:07 ` Jarkko Sakkinen
2019-02-04 12:59 ` Mimi Zohar
2019-02-04 13:21 ` Roberto Sassu
2019-02-04 23:26 ` Jarkko Sakkinen
2019-02-04 23:30 ` Jarkko Sakkinen
2019-02-05 10:02 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902041630.P1UzejFY%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=david.safford@ge.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=monty.wiseman@ge.com \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).