From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: "Safford, David (GE Global Research)" <david.safford@ge.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] Extend TPM PPI interface to support revision 1.3
Date: Sat, 9 Feb 2019 00:00:25 +0200 [thread overview]
Message-ID: <20190208220025.GB13567@linux.intel.com> (raw)
In-Reply-To: <cb86f5b6-8084-1e12-ce60-19418539b581@linux.ibm.com>
On Fri, Feb 08, 2019 at 04:21:02PM -0500, Stefan Berger wrote:
> On 1/18/19 10:00 AM, Jarkko Sakkinen wrote:
> > On Fri, Jan 11, 2019 at 08:28:00PM +0000, Safford, David (GE Global Research) wrote:
> > > You might mention that this is an important feature, as on at least some
> > > systems, ppi function 23 is the only way to enable/disable PCR banks.
> > >
> > > I have tested this patch set on my HP Spectre laptop, and I am finally
> > > able to turn the sha-1 bank on and off. Much appreciated!
> > >
> > > Tested-by: David Safford <david.safford@ge.com>
> > Great thanks David.
>
>
> While we are at it and for the grand finale of the day :-)
>
> +All you people, keep yourself alive!
> +Keep yourself alive!
> +Keep yourself alive!
> +C'mon, give me your reviewed's
> +to keep me satisfied!
> +Give me your signed-off's (1)
> +to keep me satisfied!
> +Keep yourself alive!
> +A few test-by's will keep me satisfied!
> +Keep yourself alive!
> +Check-in! (2)
> +
> +[In the style of Queen]
>
>
> Jarrko, do (1) and (2) to keep me satisfied :-)
I still think that in 5/5 branching could be better but is not a biggie
for me (does not make the implementation as whole any kind of mess) and
since it is now peer tested I rather would not modify it right now.
Applied to master and next!
/Jarkko
next prev parent reply other threads:[~2019-02-08 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 22:10 [PATCH 0/5] Extend TPM PPI interface to support revision 1.3 Stefan Berger
2019-01-09 22:10 ` [PATCH 1/5] tpm: ppi: pass function revision ID to tpm_eval_dsm() Stefan Berger
2019-01-16 21:45 ` Jarkko Sakkinen
2019-01-09 22:11 ` [PATCH 2/5] tpm: ppi: rename TPM_PPI_REVISION_ID to TPM_PPI_REVISION_1 Stefan Berger
2019-01-16 21:46 ` Jarkko Sakkinen
2019-01-09 22:11 ` [PATCH 3/5] tpm: ppi: Display up to 101 operations as define for version 1.3 Stefan Berger
2019-01-16 21:46 ` Jarkko Sakkinen
2019-01-09 22:11 ` [PATCH 4/5] tpm: ppi: Possibly show command parameter if TPM PPI 1.3 is used Stefan Berger
2019-01-16 21:48 ` Jarkko Sakkinen
2019-01-16 21:49 ` Jarkko Sakkinen
2019-01-09 22:11 ` [PATCH 5/5] tpm: ppi: Enable submission of optional command parameter for PPI 1.3 Stefan Berger
2019-01-16 21:54 ` Jarkko Sakkinen
2019-01-11 20:28 ` [PATCH 0/5] Extend TPM PPI interface to support revision 1.3 Safford, David (GE Global Research)
2019-01-14 19:51 ` Stefan Berger
2019-01-18 15:00 ` Jarkko Sakkinen
2019-02-08 21:21 ` Stefan Berger
2019-02-08 22:00 ` Jarkko Sakkinen [this message]
2019-02-08 22:06 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208220025.GB13567@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=david.safford@ge.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).