Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Peter Huewe <PeterHuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	Alexander Steffen <Alexander.Steffen@infineon.com>
Subject: Re: [PATCH v4 0/2] tpm: Unify send() callbacks
Date: Sat, 9 Feb 2019 13:08:38 -0700
Message-ID: <20190209200838.2matnb5dqlnr4qdx@cantor> (raw)
In-Reply-To: <20190208180857.12330-1-jarkko.sakkinen@linux.intel.com>

On Fri Feb 08 19, Jarkko Sakkinen wrote:
>From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.co m>
>
>A portion of send() callbacks have returned length, in many cases just
>returning back what was given as an argument, and tpm_crb has returned 0 on
>success. This patch set fixes and unifies the behaviour.
>
>v4:
>* Return zero already in tpm_tis_send_main() so that it is applied to all
>  call sites of tpm_tis_send().
>* Fixup tpm_ibmvtpm_send() documentation.
>v3:
>tpm_tis_core fix was left out of the staging area :-(
>v2:
>The drivers tpm_nsc and tpm_infineon were forgotten. For this version I
>checked both with find and command and from Kconfig that everything that is
>supposed to be a driver directly interfacing with the TPM core, is included
>(e.g. discluding tpm_tis_spi).
>
>Jarkko Sakkinen (2):
>  tpm: Unify the send callback behaviour
>  tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
>
> drivers/char/tpm/st33zp24/st33zp24.c |  2 +-
> drivers/char/tpm/tpm_atmel.c         |  2 +-
> drivers/char/tpm/tpm_i2c_atmel.c     | 10 +++++++++-
> drivers/char/tpm/tpm_i2c_infineon.c  |  2 +-
> drivers/char/tpm/tpm_i2c_nuvoton.c   |  2 +-
> drivers/char/tpm/tpm_ibmvtpm.c       |  8 ++++----
> drivers/char/tpm/tpm_infineon.c      |  2 +-
> drivers/char/tpm/tpm_nsc.c           |  2 +-
> drivers/char/tpm/tpm_tis_core.c      |  2 +-
> drivers/char/tpm/tpm_vtpm_proxy.c    |  3 +--
> drivers/char/tpm/xen-tpmfront.c      |  2 +-
> 11 files changed, 22 insertions(+), 15 deletions(-)
>
>-- 
>2.19.1
>

Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>

  parent reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 18:08 Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-08 18:12   ` Stefan Berger
2019-02-08 19:00     ` Jarkko Sakkinen
2019-02-08 19:17       ` [PATCH v4 1/2] tpm: Unify the send callback behaviourä Jarkko Sakkinen
2019-02-08 19:27         ` Stefan Berger
2019-02-08 20:23           ` Jarkko Sakkinen
2019-02-08 20:32             ` Stefan Berger
2019-02-08 20:46               ` Jarkko Sakkinen
2019-02-08 21:18                 ` Stefan Berger
2019-02-08 21:51                   ` Jarkko Sakkinen
2019-02-08 20:38             ` Jarkko Sakkinen
2019-02-11 15:05       ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Alexander Steffen
2019-02-13  7:44         ` Jarkko Sakkinen
2019-02-09 18:20   ` Jerry Snitselaar
2019-02-09 20:01     ` Jerry Snitselaar
2019-02-11 13:58     ` Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Jarkko Sakkinen
2019-02-09 20:08 ` Jerry Snitselaar [this message]
2019-02-11 14:03   ` [PATCH v4 0/2] tpm: Unify send() callbacks Jarkko Sakkinen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190209200838.2matnb5dqlnr4qdx@cantor \
    --to=jsnitsel@redhat.com \
    --cc=Alexander.Steffen@infineon.com \
    --cc=PeterHuewe@gmx.de \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org linux-integrity@archiver.kernel.org
	public-inbox-index linux-integrity


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/ public-inbox