From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F7AC43381 for ; Thu, 21 Mar 2019 13:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FB5F218D8 for ; Thu, 21 Mar 2019 13:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbfCUNp6 (ORCPT ); Thu, 21 Mar 2019 09:45:58 -0400 Received: from mga12.intel.com ([192.55.52.136]:2498 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbfCUNp6 (ORCPT ); Thu, 21 Mar 2019 09:45:58 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 06:45:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,253,1549958400"; d="scan'208";a="153822361" Received: from dilu-mobl2.ccr.corp.intel.com (HELO localhost) ([10.249.254.184]) by fmsmga002.fm.intel.com with ESMTP; 21 Mar 2019 06:45:50 -0700 Date: Thu, 21 Mar 2019 15:45:49 +0200 From: Jarkko Sakkinen To: Dan Williams Cc: keyrings@vger.kernel.org, Ira Weiny , Dave Jiang , Tyler Hicks , Keith Busch , David Howells , Vishal Verma , James Bottomley , Mimi Zohar , linux-integrity@vger.kernel.org, ecryptfs@vger.kernel.org, Roberto Sassu , linux-nvdimm , Linux Kernel Mailing List Subject: Re: [PATCH 0/6] security/keys/encrypted: Break module dependency chain Message-ID: <20190321134549.GB4603@linux.intel.com> References: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Mar 19, 2019 at 02:01:44PM -0700, Dan Williams wrote: > On Mon, Mar 18, 2019 at 11:18 PM Dan Williams wrote: > > > > With v5.1-rc1 all the nvdimm sub-system regression tests started failing > > because the libnvdimm module failed to load in the qemu-kvm test > > environment. Critically that environment does not have a TPM. Commit > > 240730437deb "KEYS: trusted: explicitly use tpm_chip structure..." > > started to require a TPM to be present for the trusted.ko module to load > > where there was no requirement for that before. > > > > Rather than undo the "fail if no hardware" behavior James points out > > that the module dependencies can be broken by looking up the key-type by > > name. Remove the dependencies on the "key_type_trusted" and > > "key_type_encrypted" symbol exports, and clean up other boilerplate that > > supported those exports in different configurations. > > Any feedback? Was hoping to get at least patch1 in the queue for > v5.1-rc2 since this effectively disables the nvdimm driver on typical > configurations. Jarkko, would you be willing to merge it since the > regression came through your tree? Yes, of course. The feedback has been extremely passive because I've been sick leave for the early week :-) Before I'm merging this I'm just thinking that would it be better idea to merge a patch for trusted.c that reverts the old behavior with cc to stable and fixes tags as I said in my earlier response. It would less intrusive for stable kernels. Lets quickly sort out the best strategy before merging. /Jarkko