From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Ignaz Forster <iforster@suse.de>, Fabian Vogt <FVogt@suse.com>,
Marcus Meissner <meissner@suse.com>,
linux-integrity@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [PATCH v2 0/3] LTP reproducer on broken IMA on overlayfs
Date: Fri, 17 May 2019 09:50:58 +0200 [thread overview]
Message-ID: <20190517075057.GA12489@dell5510> (raw)
In-Reply-To: <1558044649.4507.10.camel@linux.ibm.com>
Hi Mimi,
> > But what is strange to me is that it continues to execute second line. return 1 [2]
> > should cause ROD() to quit with TBROK [3].
> > Maybe that ROD in test1() should be replaced EXPECT_PASS.
> With just the first patch of Ignaz's path set [1] and the TPM 2.0 test
> [2], there aren't any errors. Without [1], it's now failing with the
> correct name. I'm now seeing:
I guess, that justifies [1] to be merged into kernel.
> evm_overlay 1 TINFO: $TMPDIR is on tmpfs => run on loop device
> evm_overlay 1 TINFO: Formatting /dev/loop0 with ext3 extra opts=''
> evm_overlay 1 TINFO: overwrite file in overlay
> tst_rod: Failed to open 'mntpoint/merged/foo1.txt' for writing: Permission denied
> evm_overlay 1 TFAIL: echo overlay > mntpoint/merged/foo1.txt failed unexpectedly
That still does not explain, why test doesn't exit before this last line.
I'll have a closer look into it. But as I wrote, I'll make these changes:
diff --git testcases/kernel/security/integrity/ima/tests/evm_overlay.sh testcases/kernel/security/integrity/ima/tests/evm_overlay.sh
index 08ec1ea37..1d05b9e1c 100755
--- testcases/kernel/security/integrity/ima/tests/evm_overlay.sh
+++ testcases/kernel/security/integrity/ima/tests/evm_overlay.sh
@@ -40,7 +40,7 @@ test1()
local file="foo1.txt"
tst_res TINFO "overwrite file in overlay"
- ROD echo lower \> $lower/$file
+ EXPECT_PASS echo lower \> $lower/$file
EXPECT_PASS echo overlay \> $merged/$file
}
@@ -49,7 +49,7 @@ test2()
local file="foo2.txt"
tst_res TINFO "append file in overlay"
- ROD echo lower \> $lower/$file
+ EXPECT_PASS echo lower \> $lower/$file
EXPECT_PASS echo overlay \>\> $merged/$file
}
---
If it's ok for you and it's a valid test do you give an ack?
Kind regards,
Petr
> Mimi
> [1] https://www.spinics.net/lists/linux-integrity/msg05926.html
> [2] https://lore.kernel.org/linux-integrity/1558041162.3971.2.camel@linux.ibm.com/T/#u
next prev parent reply other threads:[~2019-05-17 7:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 16:52 [PATCH v2 0/3] LTP reproducer on broken IMA on overlayfs Petr Vorel
2019-04-05 16:52 ` [PATCH v2 1/3] ima: Call test's cleanup inside ima_setup.sh cleanup Petr Vorel
2019-04-11 0:59 ` Mimi Zohar
2019-04-11 5:51 ` Petr Vorel
2019-04-11 12:22 ` Mimi Zohar
2019-04-11 20:21 ` Petr Vorel
2019-04-05 16:52 ` [PATCH v2 2/3] shell: Add $TST_DEVICE as default parameter to tst_umount Petr Vorel
2019-04-05 16:52 ` [PATCH v2 3/3] ima: Add overlay test Petr Vorel
2019-05-14 18:42 ` Ignaz Forster
2019-05-15 11:32 ` Petr Vorel
2019-05-14 12:12 ` [PATCH v2 0/3] LTP reproducer on broken IMA on overlayfs Petr Vorel
2019-05-14 19:19 ` Ignaz Forster
2019-05-15 11:34 ` Petr Vorel
2019-05-15 3:01 ` Mimi Zohar
2019-05-15 12:08 ` Petr Vorel
2019-05-16 22:10 ` Mimi Zohar
2019-05-17 7:50 ` Petr Vorel [this message]
2019-05-17 11:00 ` Mimi Zohar
2019-05-17 15:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517075057.GA12489@dell5510 \
--to=pvorel@suse.cz \
--cc=FVogt@suse.com \
--cc=iforster@suse.de \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=meissner@suse.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).