linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Matthew Garrett <matthewgarrett@google.com>
Cc: kbuild-all@01.org, linux-integrity@vger.kernel.org,
	zohar@linux.vnet.ibm.com, dmitry.kasatkin@gmail.com,
	miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk, Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH V3 1/6] VFS: Add a call to obtain a file's hash
Date: Sat, 18 May 2019 19:25:29 +0800	[thread overview]
Message-ID: <201905181919.lt0uIAPP%lkp@intel.com> (raw)
In-Reply-To: <20190517212448.14256-2-matthewgarrett@google.com>

[-- Attachment #1: Type: text/plain, Size: 4259 bytes --]

Hi Matthew,

I love your patch! Yet something to improve:

[auto build test ERROR on integrity/next-integrity]
[also build test ERROR on v5.1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matthew-Garrett/IMA-Support-asking-the-VFS-for-a-file-hash/20190518-150531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/crypto/ux500/hash/hash_core.c:39:0:
>> drivers/crypto/ux500/hash/hash_alg.h:272:6: error: nested redefinition of 'enum hash_algo'
    enum hash_algo {
         ^~~~~~~~~
>> drivers/crypto/ux500/hash/hash_alg.h:272:6: error: redeclaration of 'enum hash_algo'
   In file included from include/linux/fs.h:46:0,
                    from include/linux/huge_mm.h:8,
                    from include/linux/mm.h:527,
                    from include/linux/scatterlist.h:8,
                    from include/linux/dmaengine.h:24,
                    from drivers/crypto/ux500/hash/hash_core.c:29:
   include/uapi/linux/hash_info.h:17:6: note: originally defined here
    enum hash_algo {
         ^~~~~~~~~
   In file included from drivers/crypto/ux500/hash/hash_core.c:39:0:
>> drivers/crypto/ux500/hash/hash_alg.h:273:2: error: redeclaration of enumerator 'HASH_ALGO_SHA1'
     HASH_ALGO_SHA1  = 0x0,
     ^~~~~~~~~~~~~~
   In file included from include/linux/fs.h:46:0,
                    from include/linux/huge_mm.h:8,
                    from include/linux/mm.h:527,
                    from include/linux/scatterlist.h:8,
                    from include/linux/dmaengine.h:24,
                    from drivers/crypto/ux500/hash/hash_core.c:29:
   include/uapi/linux/hash_info.h:20:2: note: previous definition of 'HASH_ALGO_SHA1' was here
     HASH_ALGO_SHA1,
     ^~~~~~~~~~~~~~
   In file included from drivers/crypto/ux500/hash/hash_core.c:39:0:
>> drivers/crypto/ux500/hash/hash_alg.h:274:2: error: redeclaration of enumerator 'HASH_ALGO_SHA256'
     HASH_ALGO_SHA256 = 0x1
     ^~~~~~~~~~~~~~~~
   In file included from include/linux/fs.h:46:0,
                    from include/linux/huge_mm.h:8,
                    from include/linux/mm.h:527,
                    from include/linux/scatterlist.h:8,
                    from include/linux/dmaengine.h:24,
                    from drivers/crypto/ux500/hash/hash_core.c:29:
   include/uapi/linux/hash_info.h:22:2: note: previous definition of 'HASH_ALGO_SHA256' was here
     HASH_ALGO_SHA256,
     ^~~~~~~~~~~~~~~~

vim +272 drivers/crypto/ux500/hash/hash_alg.h

8a63b199 Andreas Westin 2012-04-30  266  
8a63b199 Andreas Westin 2012-04-30  267  /**
8a63b199 Andreas Westin 2012-04-30  268   * enum hash_algo - Enumeration for selecting between SHA1 or SHA2 algorithm.
8a63b199 Andreas Westin 2012-04-30  269   * @HASH_ALGO_SHA1: Indicates that SHA1 is used.
8a63b199 Andreas Westin 2012-04-30  270   * @HASH_ALGO_SHA2: Indicates that SHA2 (SHA256) is used.
8a63b199 Andreas Westin 2012-04-30  271   */
8a63b199 Andreas Westin 2012-04-30 @272  enum hash_algo {
8a63b199 Andreas Westin 2012-04-30 @273  	HASH_ALGO_SHA1		= 0x0,
8a63b199 Andreas Westin 2012-04-30 @274  	HASH_ALGO_SHA256	= 0x1
8a63b199 Andreas Westin 2012-04-30  275  };
8a63b199 Andreas Westin 2012-04-30  276  

:::::: The code at line 272 was first introduced by commit
:::::: 8a63b1994c500d4825ee73dc71502deffe5b135b crypto: ux500 - Add driver for HASH hardware

:::::: TO: Andreas Westin <andreas.westin@stericsson.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68009 bytes --]

  reply	other threads:[~2019-05-18 11:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 21:24 [PATCH V3 0/6] IMA: Support asking the VFS for a file hash Matthew Garrett
2019-05-17 21:24 ` [PATCH V3 1/6] VFS: Add a call to obtain a file's hash Matthew Garrett
2019-05-18 11:25   ` kbuild test robot [this message]
2019-05-20  7:10   ` Johannes Thumshirn
2019-05-17 21:24 ` [PATCH V3 2/6] FUSE: Allow filesystems to provide gethash methods Matthew Garrett
2019-05-17 21:24 ` [PATCH V3 3/6] IMA: Allow rule matching on filesystem subtype Matthew Garrett
2019-05-17 21:24 ` [PATCH V3 4/6] IMA: Optionally make use of filesystem-provided hashes Matthew Garrett
2019-05-17 21:24 ` [PATCH V3 5/6] IMA: Add a ima-vfs-sig measurement template Matthew Garrett
2019-05-18 10:04   ` kbuild test robot
2019-05-17 21:24 ` [PATCH V3 6/6] IMA: Allow profiles to define the desired IMA template Matthew Garrett
2019-05-17 23:47   ` Mimi Zohar
2019-05-20 20:59     ` Matthew Garrett
2019-05-20 21:26       ` Mimi Zohar
2019-05-21  0:10         ` prakhar srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201905181919.lt0uIAPP%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    --cc=miklos@szeredi.hu \
    --cc=mjg59@google.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).