From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sasha Levin <sashal@kernel.org>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@microsoft.com,
thiruan@microsoft.com, bryankel@microsoft.com
Subject: Re: [PATCH v3 1/2] ftpm: firmware TPM running in TEE
Date: Mon, 20 May 2019 14:58:27 +0300 [thread overview]
Message-ID: <20190520115827.GG27805@linux.intel.com> (raw)
In-Reply-To: <20190517132226.GB11972@sasha-vm>
On Fri, May 17, 2019 at 09:22:26AM -0400, Sasha Levin wrote:
> The whole TEE subsystem is already well documented in our kernel tree
> (https://www.kernel.org/doc/Documentation/tee.txt) and beyond. I can add
> a reference to the doc here, but I'd rather not add a bunch of TEE
> related comments as you suggest later in your review.
>
> The same way a PCI device driver doesn't describe what PCI is in it's
> code, we shouldn't be doing the same for TEE here.
Thanks for pointing out the documentation! That is sufficient.
/Jarkko
next prev parent reply other threads:[~2019-05-20 11:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 15:56 [PATCH v3 0/2] ftpm: a firmware based TPM driver Sasha Levin
2019-04-15 15:56 ` [PATCH v3 1/2] ftpm: firmware TPM running in TEE Sasha Levin
2019-05-15 8:12 ` Jarkko Sakkinen
2019-05-17 13:22 ` Sasha Levin
2019-05-20 11:58 ` Jarkko Sakkinen [this message]
2019-05-20 15:30 ` Igor Opaniuk
2019-04-15 15:56 ` [PATCH v3 2/2] ftpm: add documentation for ftpm driver Sasha Levin
2019-04-17 12:23 ` Enrico Weigelt, metux IT consult
2019-04-17 17:26 ` Sasha Levin
2019-05-15 8:14 ` Jarkko Sakkinen
2019-05-07 17:40 ` [PATCH v3 0/2] ftpm: a firmware based TPM driver Sasha Levin
2019-05-08 4:41 ` Sumit Garg
2019-05-08 8:02 ` Daniel Thompson
2019-05-08 8:24 ` Sumit Garg
2019-05-08 12:44 ` Jarkko Sakkinen
2019-05-14 19:30 ` Sasha Levin
2019-05-15 2:02 ` Sumit Garg
2019-05-16 1:00 ` Thirupathaiah Annapureddy
2019-05-16 7:06 ` Sumit Garg
2019-05-16 19:24 ` Thirupathaiah Annapureddy
2019-05-17 6:57 ` Sumit Garg
2019-05-17 17:23 ` Thirupathaiah Annapureddy
2019-05-19 9:46 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520115827.GG27805@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=bryankel@microsoft.com \
--cc=corbet@lwn.net \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sashal@kernel.org \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).