From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <jejb@linux.ibm.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
zohar@linux.ibm.com, jgg@ziepe.ca,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, crazyt2019+lml@gmail.com,
tyhicks@canonical.com, nayna@linux.vnet.ibm.com,
silviu.vlasceanu@huawei.com
Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated
Date: Tue, 9 Jul 2019 19:24:58 +0300 [thread overview]
Message-ID: <20190709162458.f4fjteokcmidv7w6@linux.intel.com> (raw)
In-Reply-To: <1562618099.20748.13.camel@linux.ibm.com>
On Mon, Jul 08, 2019 at 01:34:59PM -0700, James Bottomley wrote:
> Not a criticism of your patch, but can we please stop doing this.
> Single random number sources are horrendously bad practice because it
> gives an attacker a single target to subvert. We should ensure the TPM
> is plugged into the kernel RNG as a source and then take randomness
> from the mixed pool so it's harder for an attacker because they have to
> subvert all our sources to predict what came out.
It is and I agree.
/Jarkko
next prev parent reply other threads:[~2019-07-09 16:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:37 [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated Roberto Sassu
2019-07-08 19:55 ` Tyler Hicks
2019-07-08 20:34 ` James Bottomley
2019-07-09 16:24 ` Jarkko Sakkinen [this message]
2019-07-09 16:31 ` Mimi Zohar
2019-08-02 21:18 ` Tyler Hicks
2019-07-11 19:48 ` Jarkko Sakkinen
2019-07-15 16:44 ` Roberto Sassu
2019-08-01 16:32 ` Jarkko Sakkinen
2019-08-02 8:21 ` Roberto Sassu
2019-08-02 14:27 ` Tyler Hicks
2019-08-02 19:42 ` Jarkko Sakkinen
2019-08-02 20:23 ` Tyler Hicks
2019-08-02 20:35 ` Tyler Hicks
2019-08-03 14:44 ` Jarkko Sakkinen
2019-08-04 1:46 ` Mimi Zohar
2019-08-05 14:50 ` Roberto Sassu
2019-08-05 15:54 ` Mimi Zohar
2019-08-05 16:04 ` Roberto Sassu
2019-08-05 16:04 ` Tyler Hicks
2019-08-05 16:51 ` Roberto Sassu
2019-08-05 16:53 ` Tyler Hicks
2019-08-05 22:11 ` Jarkko Sakkinen
2019-08-02 19:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709162458.f4fjteokcmidv7w6@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=crazyt2019+lml@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=tyhicks@canonical.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).