From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10054C76186 for ; Wed, 24 Jul 2019 17:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E464F20840 for ; Wed, 24 Jul 2019 17:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbfGXR2G (ORCPT ); Wed, 24 Jul 2019 13:28:06 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:56762 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728310AbfGXR2D (ORCPT ); Wed, 24 Jul 2019 13:28:03 -0400 Received: from imap.altlinux.org (imap.altlinux.org [194.107.17.38]) by vmicros1.altlinux.org (Postfix) with ESMTP id ADD6172CCDA; Wed, 24 Jul 2019 20:28:01 +0300 (MSK) Received: from altlinux.org (sole.flsd.net [185.75.180.6]) by imap.altlinux.org (Postfix) with ESMTPSA id 93E814A4AE8; Wed, 24 Jul 2019 20:28:01 +0300 (MSK) Date: Wed, 24 Jul 2019 20:28:01 +0300 From: Vitaly Chikunov To: Mimi Zohar Cc: Petr Vorel , "BrunoE.O.Meneguele" , Dmitry Eremin-Solenikov , linux-integrity Subject: Re: ima-evm-utils: library version Message-ID: <20190724172801.y64bs2byyuqfsezf@altlinux.org> Mail-Followup-To: Mimi Zohar , Petr Vorel , "BrunoE.O.Meneguele" , Dmitry Eremin-Solenikov , linux-integrity References: <1563972698.4245.21.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1563972698.4245.21.camel@linux.ibm.com> User-Agent: NeoMutt/20171215-106-ac61c7 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Mimi, On Wed, Jul 24, 2019 at 08:51:38AM -0400, Mimi Zohar wrote: > > In preparing the ima-evm-utils v1.2 release, I noticed that the > library version was never updated. šIt is still "0.0.0". šShould I set > it to something? šIf so, what versioning scheme do you recommend - > using the libtool current[:revision[:age]], prepending the release > version on the .so, or suffixing the release version on the .so? libtool rules should be followed: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I think you should change 0.0.0 to 1.0.0 just before release. Since we are changed ABI of calc_keyid_v2 (RSA *key -> EVP_PKEY *pkey). (There is also changes to read_pub_pkey and get_filesize.) > The other option is to leave the version as 0.0.0 and let the distro > package maintainers deal with it. I think you should update it properly. > Posting a patch that sets the library version would be most welcome. diff --git a/src/Makefile.am b/src/Makefile.am index 9c037e2..b794c50 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -4,7 +4,7 @@ libimaevm_la_SOURCES = libimaevm.c libimaevm_la_CPPFLAGS = $(AM_CPPFLAGS) $(LIBCRYPTO_CFLAGS) # current[:revision[:age]] # result: [current-age].age.revision -libimaevm_la_LDFLAGS = -version-info 0:0:0 +libimaevm_la_LDFLAGS = -version-info 1:0:0 libimaevm_la_LIBADD = $(LIBCRYPTO_LIBS) Thanks,