From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: linux-integrity@vger.kernel.org, tmaimon77@gmail.com,
oshrialkoby85@gmail.com, Eyal.Cohen@nuvoton.com,
Dan.Morav@nuvoton.com
Subject: Re: [RFC PATCH 2/2] tpm: Add tpm_tis_i2c backend for tpm_tis_core
Date: Fri, 2 Aug 2019 23:20:50 +0300 [thread overview]
Message-ID: <20190802201937.26xyr7y5vxc2kk7k@linux.intel.com> (raw)
In-Reply-To: <20190718170355.6464-3-Alexander.Steffen@infineon.com>
On Thu, Jul 18, 2019 at 07:03:55PM +0200, Alexander Steffen wrote:
> +static int tpm_tis_i2c_write_bytes(struct tpm_tis_data *data, u32 addr,
> + u16 len, const u8 *value)
> +{
> + struct tpm_tis_i2c_phy *phy = to_tpm_tis_i2c_phy(data);
> + int ret;
> +
> + u8 locality[] = {
> + 0, // TPM_LOC_SEL
> + addr >> 12, // locality
> + };
> +
> + if (phy->iobuf) {
> + if (len > TPM_BUFSIZE - 1)
> + return -EIO;
> +
> + phy->iobuf[0] = address_to_register(addr);
> + memcpy(phy->iobuf + 1, value, len);
> +
> + {
> + struct i2c_msg msgs[] = {
> + {
> + .addr = phy->i2c_client->addr,
> + .len = sizeof(locality),
> + .buf = locality,
> + },
> + {
> + .addr = phy->i2c_client->addr,
> + .len = len + 1,
> + .buf = phy->iobuf,
> + },
> + };
> +
> + ret = i2c_transfer(phy->i2c_client->adapter, msgs,
> + ARRAY_SIZE(msgs));
> + }
> + } else {
> + u8 reg = address_to_register(addr);
> +
> + struct i2c_msg msgs[] = {
> + {
> + .addr = phy->i2c_client->addr,
> + .len = sizeof(locality),
> + .buf = locality,
> + },
> + {
> + .addr = phy->i2c_client->addr,
> + .len = sizeof(reg),
> + .buf = ®,
> + },
> + {
> + .addr = phy->i2c_client->addr,
> + .len = len,
> + .buf = (u8*)value,
> + .flags = I2C_M_NOSTART,
> + },
> + };
> +
> + ret = i2c_transfer(phy->i2c_client->adapter, msgs,
> + ARRAY_SIZE(msgs));
> + }
> +
> + if (ret < 0)
> + return ret;
> +
> + usleep_range(250, 300); // wait default GUARD_TIME of 250µs
This does not look good. Would prefer to have named constants.
> +
> + return 0;
> +}
You could probably simplify this by using branching for constructing
the message arrays and then use the same code path for transfer.
/Jarkko
prev parent reply other threads:[~2019-08-02 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 17:03 [RFC PATCH 0/2] tpm: Simple implementation of tpm_tis_i2c Alexander Steffen
2019-07-18 17:03 ` [RFC PATCH 1/2] tpm: Make implementation of read16/read32/write32 optional Alexander Steffen
2019-08-02 20:12 ` Jarkko Sakkinen
2022-03-15 16:14 ` [PATCH v2] " Johannes Holland
2022-03-17 8:26 ` Jarkko Sakkinen
2019-07-18 17:03 ` [RFC PATCH 2/2] tpm: Add tpm_tis_i2c backend for tpm_tis_core Alexander Steffen
2019-08-02 20:20 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802201937.26xyr7y5vxc2kk7k@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=linux-integrity@vger.kernel.org \
--cc=oshrialkoby85@gmail.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).