From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Stefan Berger" <stefanb@linux.ibm.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: Does probing of TIS with interrupts work
Date: Fri, 16 Aug 2019 00:17:01 +0300 [thread overview]
Message-ID: <20190815211701.7nhq3uelpddho7i7@linux.intel.com> (raw)
In-Reply-To: <20190813122838.GD29508@ziepe.ca>
On Tue, Aug 13, 2019 at 09:28:38AM -0300, Jason Gunthorpe wrote:
> On Mon, Aug 12, 2019 at 11:39:27PM -0400, Stefan Berger wrote:
> > I have tried to get probing of TIS with interrupts to work on a module and I
> > am wondering whether it works for anyone. I noticed it tries to probe while
> > locality 0 is released and the TPM_CHIP_FLAG_IRQ is never set, so it never
> > gets to certain places in the code. To get it to work I had to add a patch
> > like this one here to tpm_tis_core_init:
>
> It worked a long time ago, probably bitrotted
>
> We should probably drop it entirely if it doesn't even work today and
> nobody has complained.
I'd prefer to fix this.
/Jarkko
next prev parent reply other threads:[~2019-08-15 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 3:39 Does probing of TIS with interrupts work Stefan Berger
2019-08-13 12:28 ` Jason Gunthorpe
2019-08-15 21:17 ` Jarkko Sakkinen [this message]
2019-08-20 10:41 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815211701.7nhq3uelpddho7i7@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).