linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruno Meneguele <bmeneg@redhat.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH] ima-evm-utils: Enable large-file support
Date: Tue, 20 Aug 2019 12:19:39 -0300	[thread overview]
Message-ID: <20190820151939.GC7410@rhlt> (raw)
In-Reply-To: <20190819202507.27735-1-vt@altlinux.org>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Hi Vitaly,

On Mon, Aug 19, 2019 at 11:25:07PM +0300, Vitaly Chikunov wrote:
> Some architectures require special measures to access large files (LFS).
> Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this.
> 
> It seems that ABI is not changed with this.
> 
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 3f21ba4..02bd6f8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4])
>  
>  AC_CANONICAL_HOST
>  AC_USE_SYSTEM_EXTENSIONS
> +AC_SYS_LARGEFILE
>  

Should we also add AC_FUNC_FSEEKO?

I can't see any use of fseek or ftell in the code, but if we are
enabling AC_SYS_LARGEFILE by default we also should check for
AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever
needed.

>  # Checks for programs.
>  AC_PROG_CC
> -- 
> 2.11.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-08-20 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 20:25 [PATCH] ima-evm-utils: Enable large-file support Vitaly Chikunov
2019-08-20 15:19 ` Bruno Meneguele [this message]
2019-08-20 19:42   ` Vitaly Chikunov
2019-08-21 12:35     ` Bruno Meneguele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820151939.GC7410@rhlt \
    --to=bmeneg@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=vt@altlinux.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).