From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D937EC3A589 for ; Tue, 20 Aug 2019 19:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B16DF214DA for ; Tue, 20 Aug 2019 19:42:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730273AbfHTTmi (ORCPT ); Tue, 20 Aug 2019 15:42:38 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:34678 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbfHTTmi (ORCPT ); Tue, 20 Aug 2019 15:42:38 -0400 Received: from imap.altlinux.org (imap.altlinux.org [194.107.17.38]) by vmicros1.altlinux.org (Postfix) with ESMTP id 68F5472CCD5; Tue, 20 Aug 2019 22:42:36 +0300 (MSK) Received: from altlinux.org (sole.flsd.net [185.75.180.6]) by imap.altlinux.org (Postfix) with ESMTPSA id 4F50E4A4AF6; Tue, 20 Aug 2019 22:42:36 +0300 (MSK) Date: Tue, 20 Aug 2019 22:42:36 +0300 From: Vitaly Chikunov To: Bruno Meneguele Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org Subject: Re: [PATCH] ima-evm-utils: Enable large-file support Message-ID: <20190820194236.tgyhdlw5kgygcnsu@altlinux.org> Mail-Followup-To: Bruno Meneguele , Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org References: <20190819202507.27735-1-vt@altlinux.org> <20190820151939.GC7410@rhlt> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20190820151939.GC7410@rhlt> User-Agent: NeoMutt/20171215-106-ac61c7 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Bruno, On Tue, Aug 20, 2019 at 12:19:39PM -0300, Bruno Meneguele wrote: > On Mon, Aug 19, 2019 at 11:25:07PM +0300, Vitaly Chikunov wrote: > > Some architectures require special measures to access large files (LFS). > > Add `AC_SYS_LARGEFILE' to `configure.ac' to handle this. > > > > It seems that ABI is not changed with this. > > > > Signed-off-by: Vitaly Chikunov > > --- > > configure.ac | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configure.ac b/configure.ac > > index 3f21ba4..02bd6f8 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4]) > > > > AC_CANONICAL_HOST > > AC_USE_SYSTEM_EXTENSIONS > > +AC_SYS_LARGEFILE > > > > Should we also add AC_FUNC_FSEEKO? > > I can't see any use of fseek or ftell in the code, but if we are > enabling AC_SYS_LARGEFILE by default we also should check for > AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever > needed. I thought about AC_FUNC_FSEEKO, but we don't use fseeko/ftello, so it didn't look useful. Thanks, > > > # Checks for programs. > > AC_PROG_CC > > -- > > 2.11.0 > >