From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3A1C3A59E for ; Wed, 21 Aug 2019 18:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDF5D2339E for ; Wed, 21 Aug 2019 18:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728232AbfHUSNL (ORCPT ); Wed, 21 Aug 2019 14:13:11 -0400 Received: from mga05.intel.com ([192.55.52.43]:59967 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728157AbfHUSNL (ORCPT ); Wed, 21 Aug 2019 14:13:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2019 11:13:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,412,1559545200"; d="scan'208";a="203109821" Received: from kumarsh1-mobl.ger.corp.intel.com (HELO localhost) ([10.249.33.104]) by fmsmga004.fm.intel.com with ESMTP; 21 Aug 2019 11:13:06 -0700 Date: Wed, 21 Aug 2019 21:13:05 +0300 From: Jarkko Sakkinen To: Stephen Boyd Cc: Peter Huewe , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Andrey Pronin , Duncan Laurie , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Alexander Steffen Subject: Re: [PATCH v4 2/6] tpm: tpm_tis_spi: Introduce a flow control callback Message-ID: <20190821181305.e6dgrez5n4ovtg5s@linux.intel.com> References: <20190812223622.73297-1-swboyd@chromium.org> <20190812223622.73297-3-swboyd@chromium.org> <20190819163240.vsgylmctemzgqd34@linux.intel.com> <5d5ad721.1c69fb81.6a514.e649@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d5ad721.1c69fb81.6a514.e649@mx.google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Aug 19, 2019 at 10:06:40AM -0700, Stephen Boyd wrote: > > AFAIK the flow control is not part of the SPI standard itself but is > > proprietary for each slave device. Thus, the flow control should be > > documented to the source code. I do not want flow control mechanisms to > > be multiplied before this is done. > > Can you clarify this please? I don't understand what "the flow control > should be documented to the source code" means. Off the top of my head: /* TCG SPI flow control is documented in the section 6.4 of [1]. However, * Google's CR50 chip has its own proprietary flow control. This struct * is used to bind the appropriate flow control mechanism. * * [1] https://trustedcomputinggroup.org/resource/pc-client-platform-tpm-profile-ptp-specification/ */ > > > > The magic number 0x01 would be also good to get rid off. > > > > Ok. What name should the #define be? I can make that another patch. Do nothing. Not part of your patch set scope, was a stupid comment from my side. /Jarkko