From: Seunghun Han <kkamagui@gmail.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: mjg59@srcf.ucam.org, Peter Huewe <peterhuewe@gmx.de>,
linux-integrity@vger.kernel.org (open list:TPM DEVICE DRIVER),
linux-kernel@vger.kernel.org, Seunghun Han <kkamagui@gmail.com>
Subject: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM
Date: Mon, 26 Aug 2019 17:17:52 +0900 [thread overview]
Message-ID: <20190826081752.57258-1-kkamagui@gmail.com> (raw)
I'm Seunghun Han and work at the Affiliated Institute of ETRI. I got
an AMD system which had a Ryzen Threadripper 1950X and MSI mainboard, and
I had a problem with AMD's fTPM. My machine showed an error message below,
and the fTPM didn't work because of it.
[ 5.732084] tpm_crb MSFT0101:00: can't request region for resource
[mem 0x79b4f000-0x79b4ffff]
[ 5.732089] tpm_crb: probe of MSFT0101:00 failed with error -16
When I saw the e820 map and iomem, I found two fTPM regions were in
the ACPI NVS area. The regions are below.
79a39000-79b6afff : ACPI Non-volatile Storage
79b4b000-79b4bfff : MSFT0101:00
79b4f000-79b4ffff : MSFT0101:00
After analyzing this issue, I found out that a busy bit was set to
the ACPI NVS area, and the Linux kernel didn't allow the TPM CRB driver
to assign CRB regions in it.
To support AMD's fTPM, I removed the busy bit from the ACPI NVS area like
the reserved area so that AMD's fTPM regions could be assigned in it.
Signed-off-by: Seunghun Han <kkamagui@gmail.com>
---
arch/x86/kernel/e820.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 7da2bcd2b8eb..0d721df8900e 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -1085,11 +1085,12 @@ static bool __init do_mark_busy(enum e820_type type, struct resource *res)
case E820_TYPE_RESERVED:
case E820_TYPE_PRAM:
case E820_TYPE_PMEM:
+ /* AMD's fTPM regions are in the ACPI NVS area */
+ case E820_TYPE_NVS:
return false;
case E820_TYPE_RESERVED_KERN:
case E820_TYPE_RAM:
case E820_TYPE_ACPI:
- case E820_TYPE_NVS:
case E820_TYPE_UNUSABLE:
default:
return true;
--
2.21.0
next reply other threads:[~2019-08-26 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 8:17 Seunghun Han [this message]
2019-08-26 17:40 ` [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM Matthew Garrett
2019-08-27 8:23 ` Seunghun Han
2019-08-27 16:10 ` Matthew Garrett
2019-08-27 16:36 ` Seunghun Han
2019-08-27 17:11 ` Matthew Garrett
2019-08-28 9:36 ` Seunghun Han
2019-08-29 15:34 ` Jarkko Sakkinen
2019-08-29 15:39 ` Jarkko Sakkinen
2019-08-29 16:12 ` Seunghun Han
2019-08-30 10:01 ` Seunghun Han
2019-08-27 12:47 ` Jarkko Sakkinen
2019-08-27 15:49 ` Seunghun Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826081752.57258-1-kkamagui@gmail.com \
--to=kkamagui@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).