From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD01CC3A59F for ; Mon, 26 Aug 2019 14:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 930CF21848 for ; Mon, 26 Aug 2019 14:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566828095; bh=gPz4wzPC17jbgMO86fVkOAlhLpUk0FXF6vl4/58WHts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NDvniPfQFoc03rYMe3MYCMKlumTVTTCwlgvnOoTeUSgL0Y9k4cpD3akwn84nanX3j m/ewTGPSzBPYPHrxXxw/tHZB27wxArBXUM0DwZ8kO7am4VNt/lT0CU0YSyMq98rSbD MFitLqwHRVGsCIJWB+5XNw4sMdgMgcWKNDXisrTg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728921AbfHZOBf (ORCPT ); Mon, 26 Aug 2019 10:01:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:53342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728760AbfHZOBf (ORCPT ); Mon, 26 Aug 2019 10:01:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFDBB2173E; Mon, 26 Aug 2019 14:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566828094; bh=gPz4wzPC17jbgMO86fVkOAlhLpUk0FXF6vl4/58WHts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tlMjEtZ/iEjWrikes+vLlInuU046SluV9TWPapUiXpJt/+bPV12BRKcf0Q4/FMFUB Q3eGS7vM/v7cSmwjsdkUHluJswE6k0jlwNahYu1SPgkS0vpB6w3XaQbk1izIuX453X FlTc/fr819cZx7DdefGzUll8THxgEnejTsIiBA0o= Date: Mon, 26 Aug 2019 16:01:31 +0200 From: Greg Kroah-Hartman To: Nayna Jain Cc: linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ard Biesheuvel , Jeremy Kerr , Matthew Garret , Mimi Zohar , Claudio Carvalho , George Wilson , Elaine Palmer , Eric Ricther , Oliver O'Halloran Subject: Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Message-ID: <20190826140131.GA15270@kroah.com> References: <1566825818-9731-1-git-send-email-nayna@linux.ibm.com> <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct bin_attribute update_attr = { > + .attr = {.name = "update", .mode = 0200}, > + .size = VARIABLE_MAX_SIZE, > + .write = update_write, > +}; Ah, do we need a __BIN_ATTR_WO() macro for you? That would make this more obvious, right? Other than that minor thing (not a complaint at all) looks much better to me, nice work: Reviewed-by: Greg Kroah-Hartman