From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C84DC3A59F for ; Thu, 29 Aug 2019 16:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7816321874 for ; Thu, 29 Aug 2019 16:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727673AbfH2QLI (ORCPT ); Thu, 29 Aug 2019 12:11:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:55966 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727257AbfH2QLH (ORCPT ); Thu, 29 Aug 2019 12:11:07 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 09:11:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,444,1559545200"; d="scan'208";a="380819693" Received: from friedlmi-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.54.26]) by fmsmga005.fm.intel.com with ESMTP; 29 Aug 2019 09:11:03 -0700 Date: Thu, 29 Aug 2019 19:10:57 +0300 From: Jarkko Sakkinen To: Stefan Berger Cc: Stefan Berger , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm_tis: Fix interrupt probing Message-ID: <20190829161057.22l72j55jy3dyib7@linux.intel.com> References: <20190820122517.2086223-1-stefanb@linux.vnet.ibm.com> <20190827131400.qchcwa2act24c47b@linux.intel.com> <20190827151915.hb4xwr2vik2i5ryb@linux.intel.com> <797ff54e-dceb-21d2-dd74-e5244f9c6dfd@linux.ibm.com> <20190829132021.6vfc535ecb62jokf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829132021.6vfc535ecb62jokf@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Aug 29, 2019 at 04:20:21PM +0300, Jarkko Sakkinen wrote: > On Tue, Aug 27, 2019 at 03:34:36PM -0400, Stefan Berger wrote: > > On 8/27/19 11:19 AM, Jarkko Sakkinen wrote: > > > On Tue, Aug 27, 2019 at 04:14:00PM +0300, Jarkko Sakkinen wrote: > > > > On Tue, Aug 20, 2019 at 08:25:17AM -0400, Stefan Berger wrote: > > > > > From: Stefan Berger > > > > > > > > > > The interrupt probing of the TPM TIS was broken since we are trying to > > > > > run it without an active locality and without the TPM_CHIP_FLAG_IRQ set. > > > > > > > > > > Signed-off-by: Stefan Berger > > > > Need these: > > > > > > > > Cc: linux-stable@vger.kernel.org > > > > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > > > > > > > > Thank you. I'll apply this to my tree. > > > > > > > > Reviewed-by: Jarkko Sakkinen > > > The commit went in the following form: > > > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/9b558deab2c5d7dc23d5f7a4064892ede482ad32 > > > > I saw you dropped the stetting of the IRQ flag - I needed it, otherwise it > > wouldn't execute certain code paths. > > I explained why I removed that part. There was no any reasoning for > it. Also, it cannot be in the same commit if it fixes a diffent > issue. AFAIK they go with different fixes-tags. /Jarkko