From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8278C3A59F for ; Thu, 29 Aug 2019 18:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB8692077B for ; Thu, 29 Aug 2019 18:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727697AbfH2SEu (ORCPT ); Thu, 29 Aug 2019 14:04:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53016 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbfH2SEt (ORCPT ); Thu, 29 Aug 2019 14:04:49 -0400 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FE524E926 for ; Thu, 29 Aug 2019 18:04:48 +0000 (UTC) Received: by mail-qk1-f199.google.com with SMTP id y188so4386523qke.18 for ; Thu, 29 Aug 2019 11:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=/g56CbzY6jStnVFv4SmkcoSCqpGf1hqTgm+yJUl5UlM=; b=jK0OSJjapqLrXrCTsc2CUtvP7VgGjYtQlqjVu228duuKD2T/pD1uMYoGZo2VcAgon2 tJ+Yy3nsgmFVYcCKWyC0d7GbVSeyvnxzpWhW9VPUI/sLR3uiooVdReGO9XxmT8Ns0JLO xe/mfKQPvvDXQ3ycq5zpvV6g2fOWJtcgquZ5bQWweVGiIQkzu1pRITEXRTTvSeG4opPY +nBYM4Sh/hiPwbOpk7za352As3DE/wPEloZxh8YcGVG5Ue/Pf1i6V2sQ9rEDhnv5G/5Z cQzYBpBG9xUtGSht9yVSr3oo0vCI183vLPsJ9JtiXHlEYDQPYDTTW6Le6QfyewjsvjBa MXNg== X-Gm-Message-State: APjAAAXAl1wviFtKTNQ4v9xqqty09eP0D/sSpKxywRvXkHRvRLx8vfP+ vu6fkoW0ZKsgJzuRAqejJQhQS5U0q56c8qFqSpTB9v3w5nYnJmMnKwSsQtAhvXkvByP3CI7rQPL Gl2KlF89e5QHf9h5DXq/zwbRahve9 X-Received: by 2002:aed:3f47:: with SMTP id q7mr11204047qtf.209.1567101886977; Thu, 29 Aug 2019 11:04:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRJwR4t1+ktKs4jFtCVoCNuKYwztEr1VyG5hto1oCuAaOHgiMXYRCME7xxyoCfhNCc+9WZfw== X-Received: by 2002:aed:3f47:: with SMTP id q7mr11203999qtf.209.1567101886606; Thu, 29 Aug 2019 11:04:46 -0700 (PDT) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id t189sm1634698qkd.56.2019.08.29.11.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 11:04:45 -0700 (PDT) Date: Thu, 29 Aug 2019 11:04:44 -0700 From: Jerry Snitselaar To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Alexey Klimov Subject: Re: [PATCH 2/2 v2] tpm_tis: override durations for STM tpm with firmware 1.2.8.28 Message-ID: <20190829180444.jkwqxgithvbjqtfi@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Alexey Klimov References: <20190828004621.29050-1-jsnitsel@redhat.com> <20190828004621.29050-3-jsnitsel@redhat.com> <20190829144002.zhuqxnsswgl65pnm@linux.intel.com> <20190829144140.6xaygqkfhsnmm67s@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190829144140.6xaygqkfhsnmm67s@linux.intel.com> User-Agent: NeoMutt/20180716 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu Aug 29 19, Jarkko Sakkinen wrote: >On Thu, Aug 29, 2019 at 05:40:40PM +0300, Jarkko Sakkinen wrote: >> On Tue, Aug 27, 2019 at 05:46:21PM -0700, Jerry Snitselaar wrote: >> > There was revealed a bug in the STM TPM chipset used in Dell R415s. >> > Bug is observed so far only on chipset firmware 1.2.8.28 >> > (1.2 TPM, device-id 0x0, rev-id 78). After some number of >> > operations chipset hangs and stays in inconsistent state: >> > >> > tpm_tis 00:09: Operation Timed out >> > tpm_tis 00:09: tpm_transmit: tpm_send: error -5 >> > >> > Durations returned by the chip are the same like on other >> > firmware revisions but apparently with specifically 1.2.8.28 fw >> > durations should be reset to 2 minutes to enable tpm chip work >> > properly. No working way of updating firmware was found. >> > >> > This patch adds implementation of ->update_durations method >> > that matches only STM devices with specific firmware version. >> > >> > Cc: Peter Huewe >> > Cc: Jarkko Sakkinen >> > Cc: Jason Gunthorpe >> > Signed-off-by: Alexey Klimov >> > Signed-off-by: Jerry Snitselaar >> > --- >> > v2: Make suggested changes from Jarkko >> > - change struct field name to durations from durs >> > - formatting cleanups >> > - turn into void function like update_timeouts and >> > use chip->duration_adjusted to track whether adjustment occurred. >> >> The code repetition looks horrible so I wrote a patch that should help: >> >> https://patchwork.kernel.org/patch/11121475/ >> >> Read the remar that prepends the diffstat. > >Forgot from that remark that I did not have TPM 1.x available at hand >(WFH today) so please also review and test it. > >/Jrakko I will test it this morning, and once that is done I'll submit a v3 that cleans up the version comparison in the update_durations function.