archive mirror
 help / color / mirror / Atom feed
From: Jerry Snitselaar <>
To: Jarkko Sakkinen <>
	Peter Huewe <>, Jason Gunthorpe <>,
	Alexey Klimov <>
Subject: Re: [PATCH 2/2 v2] tpm_tis: override durations for STM tpm with firmware
Date: Thu, 29 Aug 2019 13:25:27 -0700	[thread overview]
Message-ID: <20190829202527.auyqek7yryuvaruk@cantor> (raw)
In-Reply-To: <>

On Thu Aug 29 19, Jarkko Sakkinen wrote:
>On Tue, Aug 27, 2019 at 05:46:21PM -0700, Jerry Snitselaar wrote:
>> There was revealed a bug in the STM TPM chipset used in Dell R415s.
>> Bug is observed so far only on chipset firmware
>> (1.2 TPM, device-id 0x0, rev-id 78). After some number of
>> operations chipset hangs and stays in inconsistent state:
>> tpm_tis 00:09: Operation Timed out
>> tpm_tis 00:09: tpm_transmit: tpm_send: error -5
>> Durations returned by the chip are the same like on other
>> firmware revisions but apparently with specifically fw
>> durations should be reset to 2 minutes to enable tpm chip work
>> properly. No working way of updating firmware was found.
>> This patch adds implementation of ->update_durations method
>> that matches only STM devices with specific firmware version.
>> Cc: Peter Huewe <>
>> Cc: Jarkko Sakkinen <>
>> Cc: Jason Gunthorpe <>
>> Signed-off-by: Alexey Klimov <>
>> Signed-off-by: Jerry Snitselaar <>
>> ---
>> v2: Make suggested changes from Jarkko
>>     - change struct field name to durations from durs
>>     - formatting cleanups
>>     - turn into void function like update_timeouts and
>>       use chip->duration_adjusted to track whether adjustment occurred.
>The code repetition looks horrible so I wrote a patch that should help:
>Read the remar that prepends the diffstat.

LGTM, and testing it on a 1.2 tpm system here worked fine. You can add my
Reviewed-by and Tested-by.

I have reworked this 2/2 patch to make use of these new structs and
pull the tpm1_getcap calls out of the for loop. So I will submit a v3
to go on top of your patch.

  parent reply	other threads:[~2019-08-29 20:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  0:46 [PATCH 0/2 v2] tpm: add update_durations class op to allow override of chip supplied values Jerry Snitselaar
2019-08-28  0:46 ` [PATCH 1/2 v2] tpm: provide a way to override the chip returned durations Jerry Snitselaar
2019-08-29 13:27   ` Jarkko Sakkinen
2019-08-28  0:46 ` [PATCH 2/2 v2] tpm_tis: override durations for STM tpm with firmware Jerry Snitselaar
2019-08-29 14:40   ` Jarkko Sakkinen
2019-08-29 14:41     ` Jarkko Sakkinen
2019-08-29 18:04       ` Jerry Snitselaar
2019-08-29 20:25     ` Jerry Snitselaar [this message]
2019-08-29 22:23       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829202527.auyqek7yryuvaruk@cantor \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).