From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559AFC4CEC7 for ; Sat, 14 Sep 2019 13:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BE7520854 for ; Sat, 14 Sep 2019 13:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388586AbfINNEr (ORCPT ); Sat, 14 Sep 2019 09:04:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:18258 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388575AbfINNEr (ORCPT ); Sat, 14 Sep 2019 09:04:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2019 06:04:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="188149021" Received: from krusocki-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.34]) by orsmga003.jf.intel.com with ESMTP; 14 Sep 2019 06:04:42 -0700 Date: Sat, 14 Sep 2019 14:04:41 +0100 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, jsnitsel@redhat.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v4] KEYS: trusted: correctly initialize digests and fix locking issue Message-ID: <20190914130441.GE9560@linux.intel.com> References: <20190913185136.780-1-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913185136.780-1-roberto.sassu@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, Sep 13, 2019 at 08:51:36PM +0200, Roberto Sassu wrote: > Commit 0b6cf6b97b7e ("tpm: pass an array of tpm_extend_digest structures to > tpm_pcr_extend()") modifies tpm_pcr_extend() to accept a digest for each > PCR bank. After modification, tpm_pcr_extend() expects that digests are > passed in the same order as the algorithms set in chip->allocated_banks. > > This patch fixes two issues introduced in the last iterations of the patch > set: missing initialization of the TPM algorithm ID in the tpm_digest > structures passed to tpm_pcr_extend() by the trusted key module, and > unreleased locks in the TPM driver due to returning from tpm_pcr_extend() > without calling tpm_put_ops(). > > Signed-off-by: Roberto Sassu > Suggested-by: Jarkko Sakkinen > Reviewed-by: Jerry Snitselaar > Fixes: 0b6cf6b97b7e ("tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()") Reviewed-by: I picked up this patch to my tree. /Jarkko