archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <>
Cc: Mimi Zohar <>,, Peter Huewe <>,
	Jason Gunthorpe <>, Arnd Bergmann <>,
	Greg Kroah-Hartman <>,
	open list <>
Subject: Re: [PATCH] tpm: Fix tpm_send() length calculation
Date: Mon, 16 Sep 2019 10:46:57 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Sep 16, 2019 at 10:35:35AM +0300, Jarkko Sakkinen wrote:
> Set the size of the tpm_buf correctly. Now it is set to the header
> length by tpm_buf_init().
> Reported-by: Mimi Zohar <>
> Cc:
> Fixes: 412eb585587a ("use tpm_buf in tpm_transmit_cmd() as the IO parameter")
> Signed-off-by: Jarkko Sakkinen <>

This is all wrong in all possible ways :-( My excuse is the overnight
flight last night (no sleep). Mimi, I think what you first proposed as
the fix is the right way tho fix it. I'll take some sleep and after that
I'll make a legit commit with fix and a commit message explaining the
root cause.

Please try to ignore this.


  reply	other threads:[~2019-09-16  7:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16  7:35 [PATCH] tpm: Fix tpm_send() length calculation Jarkko Sakkinen
2019-09-16  7:46 ` Jarkko Sakkinen [this message]
2019-09-16 12:06   ` LPC System Boot and Security Microconference (subject change) Mimi Zohar
2019-09-16 13:44     ` Jerry Snitselaar
2019-09-16 16:02       ` Piotr Król
2019-09-16  9:52 ` [PATCH] tpm: Fix tpm_send() length calculation kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).