From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: dhowells@redhat.com, peterhuewe@gmx.de, keyrings@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org, jejb@linux.ibm.com,
zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com,
jsnitsel@redhat.com, linux-kernel@vger.kernel.org,
daniel.thompson@linaro.org
Subject: Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code
Date: Tue, 17 Sep 2019 21:14:15 +0300 [thread overview]
Message-ID: <20190917181415.GA8472@linux.intel.com> (raw)
In-Reply-To: <1568630064-14887-5-git-send-email-sumit.garg@linaro.org>
On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote:
> Move TPM2 trusted keys code to trusted keys subsystem. The reason
> being it's better to consolidate all the trusted keys code to a single
> location so that it can be maintained sanely.
>
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
This commit has couple of issues that I only noticed when looking into
bug reported by Mimi.
Right now tpm_send() is the exported function that is used by other
subsystems. tpm_transmit_cmd() is an internal function. This commit adds
two unrelated code paths to send TPM commands, which is unacceptable.
You should make tpm2 functionality to use tpm_send() instead and remove
tpm_seal_trusted() and tpm_unseal_trusted() completely in this commit.
/Jarkko
next prev parent reply other threads:[~2019-09-17 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 10:34 [Patch v6 0/4] Create and consolidate trusted keys subsystem Sumit Garg
2019-09-16 10:34 ` [Patch v6 1/4] tpm: Move tpm_buf code to include/linux/ Sumit Garg
2019-09-16 10:34 ` [Patch v6 2/4] KEYS: Use common tpm_buf for trusted and asymmetric keys Sumit Garg
2019-09-16 10:34 ` [Patch v6 3/4] KEYS: trusted: Create trusted keys subsystem Sumit Garg
2019-09-16 10:34 ` [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code Sumit Garg
2019-09-17 18:14 ` Jarkko Sakkinen [this message]
2019-09-17 18:15 ` Jarkko Sakkinen
2019-09-18 6:23 ` Sumit Garg
2019-09-25 1:11 ` Jarkko Sakkinen
2019-10-04 6:05 ` Sumit Garg
2019-10-04 18:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917181415.GA8472@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).