linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-stabley@vger.kernel.org,
	Vadim Sukhomlinov <sukhomlinov@google.com>,
	stable@vger.kernel.org, Douglas Anderson <dianders@chromium.org>,
	Peter Huewe <peterhuewe@gmx.de>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Date: Wed, 2 Oct 2019 08:31:23 -0700	[thread overview]
Message-ID: <20191002153123.wcguist4okoxckis@cantor> (raw)
In-Reply-To: <20191002151751.GP17454@sasha-vm>

On Wed Oct 02 19, Sasha Levin wrote:
>On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote:
>>On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote:
>>>From: Vadim Sukhomlinov <sukhomlinov@google.com>
>>>
>>>commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
>>>
>>>TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
>>>future TPM operations. TPM 1.2 behavior was different, future TPM
>>>operations weren't disabled, causing rare issues. This patch ensures
>>>that future TPM operations are disabled.
>>>
>>>Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
>>>Cc: stable@vger.kernel.org
>>>Signed-off-by: Vadim Sukhomlinov <sukhomlinov@google.com>
>>>[dianders: resolved merge conflicts with mainline]
>>>Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>>Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>>Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>>---
>>> drivers/char/tpm/tpm-chip.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>>What kernel version(s) is this for?
>
>It would go to 4.19, we've recently reverted an incorrect backport of
>this patch.
>
>Jarkko, why is this patch 3/3? We haven't seen the first two on the
>mailing list, do we need anything besides this patch?
>
>--
>Thanks,
>Sasha

It looks like there was a problem mailing the earlier patchset, and patches 1 and 2
weren't cc'd to stable, but patch 3 was.


  reply	other threads:[~2019-10-02 15:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 13:14 [PATCH 0/3] " Jarkko Sakkinen
2019-10-02 13:14 ` [PATCH 1/3] tpm: migrate pubek_show to struct tpm_buf Jarkko Sakkinen
2019-10-02 13:14 ` [PATCH 2/3] tpm: use tpm_try_get_ops() in tpm-sysfs.c Jarkko Sakkinen
2019-10-02 13:14 ` [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Jarkko Sakkinen
2019-10-02 13:57   ` Greg KH
2019-10-02 15:17     ` Sasha Levin
2019-10-02 15:31       ` Jerry Snitselaar [this message]
2019-10-02 15:42         ` Jerry Snitselaar
2019-10-02 16:09           ` Greg KH
2019-10-03 11:24           ` Jarkko Sakkinen
2019-10-03 11:25             ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2019-10-03 11:24 [PATCH 0/3] " Jarkko Sakkinen
2019-10-03 11:24 ` [PATCH 3/3] " Jarkko Sakkinen
2019-09-25 10:15 [PATCH 0/3] " Jarkko Sakkinen
2019-09-25 10:15 ` [PATCH 3/3] " Jarkko Sakkinen
2019-09-26 23:22   ` Sasha Levin
2019-09-24 14:01 [PATCH 0/3] " Jarkko Sakkinen
2019-09-24 14:02 ` [PATCH 3/3] " Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002153123.wcguist4okoxckis@cantor \
    --to=jsnitsel@redhat.com \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stabley@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sukhomlinov@google.com \
    --subject='Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).