From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37008C10F14 for ; Thu, 3 Oct 2019 11:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1313E20673 for ; Thu, 3 Oct 2019 11:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729895AbfJCLZn (ORCPT ); Thu, 3 Oct 2019 07:25:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:51919 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725827AbfJCLZn (ORCPT ); Thu, 3 Oct 2019 07:25:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 04:25:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,251,1566889200"; d="scan'208";a="198503176" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.161]) by FMSMGA003.fm.intel.com with ESMTP; 03 Oct 2019 04:25:39 -0700 Date: Thu, 3 Oct 2019 14:25:39 +0300 From: Jarkko Sakkinen To: Sasha Levin , Greg KH , linux-stabley@vger.kernel.org, Vadim Sukhomlinov , stable@vger.kernel.org, Douglas Anderson , Peter Huewe , Jason Gunthorpe , "open list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Message-ID: <20191003112539.GB8933@linux.intel.com> References: <20191002131445.7793-1-jarkko.sakkinen@linux.intel.com> <20191002131445.7793-4-jarkko.sakkinen@linux.intel.com> <20191002135758.GA1738718@kroah.com> <20191002151751.GP17454@sasha-vm> <20191002153123.wcguist4okoxckis@cantor> <20191002154204.me4lzgx2l4r6zkpy@cantor> <20191003112442.GA8933@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191003112442.GA8933@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Oct 03, 2019 at 02:24:42PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 02, 2019 at 08:42:04AM -0700, Jerry Snitselaar wrote: > > On Wed Oct 02 19, Jerry Snitselaar wrote: > > > On Wed Oct 02 19, Sasha Levin wrote: > > > > On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote: > > > > > On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote: > > > > > > From: Vadim Sukhomlinov > > > > > > > > > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream > > > > > > > > > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > > > > > > future TPM operations. TPM 1.2 behavior was different, future TPM > > > > > > operations weren't disabled, causing rare issues. This patch ensures > > > > > > that future TPM operations are disabled. > > > > > > > > > > > > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") > > > > > > Cc: stable@vger.kernel.org > > > > > > Signed-off-by: Vadim Sukhomlinov > > > > > > [dianders: resolved merge conflicts with mainline] > > > > > > Signed-off-by: Douglas Anderson > > > > > > Reviewed-by: Jarkko Sakkinen > > > > > > Signed-off-by: Jarkko Sakkinen > > > > > > --- > > > > > > drivers/char/tpm/tpm-chip.c | 5 +++-- > > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > > What kernel version(s) is this for? > > > > > > > > It would go to 4.19, we've recently reverted an incorrect backport of > > > > this patch. > > > > > > > > Jarkko, why is this patch 3/3? We haven't seen the first two on the > > > > mailing list, do we need anything besides this patch? > > > > > > > > -- > > > > Thanks, > > > > Sasha > > > > > > It looks like there was a problem mailing the earlier patchset, and patches 1 and 2 > > > weren't cc'd to stable, but patch 3 was. > > > > Is linux-stabley@vger.kernel.org a valid address? > > > > No, did a resend :-( New version sent to stableish@vger.kernel.org. /Jarkko