From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B70FA3728 for ; Wed, 16 Oct 2019 15:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEE3C2067D for ; Wed, 16 Oct 2019 15:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394126AbfJPP1j (ORCPT ); Wed, 16 Oct 2019 11:27:39 -0400 Received: from mga18.intel.com ([134.134.136.126]:64212 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394125AbfJPP1j (ORCPT ); Wed, 16 Oct 2019 11:27:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 08:27:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,304,1566889200"; d="scan'208";a="370830735" Received: from hagarwal-mobl1.gar.corp.intel.com (HELO localhost) ([10.252.5.165]) by orsmga005.jf.intel.com with ESMTP; 16 Oct 2019 08:27:33 -0700 Date: Wed, 16 Oct 2019 18:27:31 +0300 From: Jarkko Sakkinen To: Heiko Stuebner Cc: Stephen Boyd , Peter Huewe , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Andrey Pronin , Duncan Laurie , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Alexander Steffen Subject: Re: [PATCH v7 0/6] tpm: Add driver for cr50 Message-ID: <20191016152731.GD4261@linux.intel.com> References: <20190920183240.181420-1-swboyd@chromium.org> <4042311.vcUrecXYXX@diego> <20191014195607.GK15552@linux.intel.com> <11998737.dOvWaeisEJ@phil> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11998737.dOvWaeisEJ@phil> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Oct 15, 2019 at 10:23:15PM +0200, Heiko Stuebner wrote: > Hi, > > Am Montag, 14. Oktober 2019, 21:56:30 CEST schrieb Jarkko Sakkinen: > > On Fri, Oct 11, 2019 at 09:50:27AM +0200, Heiko Stübner wrote: > > > Am Montag, 7. Oktober 2019, 00:39:00 CEST schrieb Jarkko Sakkinen: > > > > On Fri, Sep 20, 2019 at 11:32:34AM -0700, Stephen Boyd wrote: > > > > > This patch series adds support for the H1 secure microcontroller > > > > > running cr50 firmware found on various recent Chromebooks. This driver > > > > > is necessary to boot into a ChromeOS userspace environment. It > > > > > implements support for several functions, including TPM-like > > > > > functionality over a SPI interface. > > > > > > > > > > The last time this was series sent looks to be [1]. I've looked over the > > > > > patches and review comments and tried to address any feedback that > > > > > Andrey didn't address (really minor things like newlines). I've reworked > > > > > the patches from the last version to layer on top of the existing TPM > > > > > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more > > > > > palatable than combining the two drivers together into one file. > > > > > > > > > > Please review so we can get the approach to supporting this device > > > > > sorted out. > > > > > > > > > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@chromium.org > > > > > > [...] > > > > > > > OK, so, I put these to my master in hopes to get testing exposure. > > > > I think the changes are in great shape now. Thank you. > > > > > > on a rk3399-gru-bob it works nicely for me, so > > > Tested-by: Heiko Stuebner > > > > Thank you! I updated my tree with your tag. Mind if I also add > > reviewed-by's? > > I think I did spent enough time with the patches to warrant that, so > Reviewed-by: Heiko Stuebner Thank you! /Jarkko