linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-integrity@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] tpm: Switch to platform_get_irq_optional()
Date: Thu, 24 Oct 2019 17:25:19 +0300	[thread overview]
Message-ID: <20191024142519.GA3881@linux.intel.com> (raw)
In-Reply-To: <d6adeb21-f7b3-5c64-fa32-03a8ee21cc53@redhat.com>

On Wed, Oct 23, 2019 at 04:32:57PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 23-10-2019 13:37, Jarkko Sakkinen wrote:
> > On Mon, Oct 21, 2019 at 05:56:56PM +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 21-10-2019 17:49, Jarkko Sakkinen wrote:
> > > > On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote:
> > > > > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> > > > > platform_get_irq*()"), platform_get_irq() will call dev_err() on an error,
> > > > > as the IRQ usage in the tpm_tis driver is optional, this is undesirable.
> > > > > 
> > > > > Specifically this leads to this new false-positive error being logged:
> > > > > [    5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
> > > > > 
> > > > > This commit switches to platform_get_irq_optional(), which does not log
> > > > > an error, fixing this.
> > > > > 
> > > > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > > 
> > > > Incorrect format (should be wo '<' and '>').
> > > 
> > > According to:
> > > 
> > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > > 
> > > the '<' and '>' should be added when adding a # <kerner>
> > 
> > OK, right so it was. This first patch that I'm reviewing with such
> > commit.
> > 
> > > > Also, not sure why this should be backported to stable kernel anyway.
> > > 
> > > Because false-positive error messages are bad and cause users to
> > > file false-positive bug-reports.
> > 
> > Neither categorizes into a regression albeit being unfortunate
> > glitches.
> 
> The stable series also does other small fixes, such as adding new
> pci/usb-ids, etc. This clearly falls within this. IMHO ideally this
> should go to a 5.4-rc# making the whole discussion moot, but since
> I was afraid it would not make 5.4, I added the Cc: stable.

I get adding PCI/USB id as it extends the hardware support for the
stable kernel without risking its stability. This patch is factors
less useful.

/Jarkko

  reply	other threads:[~2019-10-24 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19  9:45 [PATCH] tpm: Switch to platform_get_irq_optional() Hans de Goede
2019-10-21 14:05 ` Jason Gunthorpe
2019-10-23 11:32   ` Jarkko Sakkinen
2019-10-24 15:36     ` Jason Gunthorpe
2019-10-21 15:49 ` Jarkko Sakkinen
2019-10-21 15:56   ` Hans de Goede
2019-10-23 11:37     ` Jarkko Sakkinen
2019-10-23 14:32       ` Hans de Goede
2019-10-24 14:25         ` Jarkko Sakkinen [this message]
2019-10-24 14:27           ` Hans de Goede
2019-10-24 19:09             ` Jarkko Sakkinen
2019-10-24 19:11               ` Jason Gunthorpe
2019-10-25  9:13               ` Hans de Goede
2019-10-28 20:47                 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024142519.GA3881@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).