From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>,
linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: Add major_version sysfs file
Date: Sun, 27 Oct 2019 20:00:46 -0300 [thread overview]
Message-ID: <20191027230046.GJ23952@ziepe.ca> (raw)
In-Reply-To: <20191027153541.GA5222@linux.intel.com>
On Sun, Oct 27, 2019 at 05:35:41PM +0200, Jarkko Sakkinen wrote:
> On Fri, Oct 25, 2019 at 07:28:47AM -0700, Jerry Snitselaar wrote:
> > Easily determining what TCG version a tpm device implements
> > has been a pain point for userspace for a long time, so
> > add a sysfs file to report the tcg version of a tpm device.
> >
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Peter Huewe <peterhuewe@gmx.de>
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Cc: linux-integrity@vger.kernel.org
> > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>
> Please use version_major (e.g. if there is ever version_minor
> they order nicely alphabetically).
That is not the convention in sysfs
Jason
next prev parent reply other threads:[~2019-10-27 23:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 14:28 [PATCH] tpm: Add major_version sysfs file Jerry Snitselaar
2019-10-25 18:18 ` Mimi Zohar
2019-10-25 18:45 ` Jerry Snitselaar
2019-10-25 19:15 ` Mimi Zohar
2019-10-25 19:32 ` Jason Gunthorpe
2019-10-25 19:42 ` Mimi Zohar
2019-10-27 23:01 ` Jason Gunthorpe
2019-10-27 15:35 ` Jarkko Sakkinen
2019-10-27 23:00 ` Jason Gunthorpe [this message]
2019-10-29 9:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027230046.GJ23952@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).