Re: [PATCH] tpm: remove tpm_dev_wq_lock

[Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>]

On Mon, Oct 28, 2019 at 10:24:19PM +0200, Jarkko Sakkinen wrote:
> On Mon, Oct 14, 2019 at 10:39:42PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Oct 10, 2019 at 06:03:13PM +0200, Sebastian Andrzej Siewior wrote:
> > > On 2019-02-11 16:11:45 [+0200], Jarkko Sakkinen wrote:
> > > > On Mon, Feb 11, 2019 at 11:58:35AM +0100, Sebastian Andrzej Siewior wrote:
> > > > > Added in commit
> > > > > 
> > > > >   9e1b74a63f776 ("tpm: add support for nonblocking operation")
> > > > > 
> > > > > but never actually used it.
> > > > > 
> > > > > Cc: Philip Tricca <philip.b.tricca@intel.com>
> > > > > Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> > > > > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > > > 
> > > > You should use Fixes-tag e.g.
> > > > 
> > > > Fixes: <12 first chars from SHA-1> ("<short summary>")
> > > 
> > > Is this the only reason why it has not been picked up? A fixes line
> > > which triggers stable backports for something that does need to be
> > > backported?
> > 
> > Fully agree with you. Frankly, I don't really remember anymore why I
> > responded that way. My guess is that I responded that to a worng patch.
> > 
> > Please just ping immediatelly. Sometimes when dealing with dozens of
> > patches this kind of human error might happen.
> > 
> > In any case, the patch is applied.
> 
> OK, so. Gave a relook at this:
> 
> This gives checkpatch.pl error:
> 
> 0012-tpm-remove-tpm_dev_wq_lock.patch
> -------------------------------------
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9e1b74a63f77 ("tpm: add support for nonblocking operation")'
> #8: 
>   9e1b74a63f776 ("tpm: add support for nonblocking operation")
> 
> total: 1 errors, 0 warnings, 7 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> Please send me a new patch with a legit fixes line. It is a fix to
> regression even if it is a cosmetic one.
> 
> I'll drop the current patch from my tree and apply a new one once
> I get it from you.
> 
> Thanks.
> 
> /Jarkko

AFAIK cc stable triggers stable backport, not fixes line alone (not
100% sure about this though). Anyway even my original response was
meant to this patch I recall now that I bumped into that checkpatch
error.

/Jarkko