Linux-Integrity Archive on
 help / color / Atom feed
From: Jarkko Sakkinen <>
To: Hans de Goede <>
Cc: Peter Huewe <>, Jason Gunthorpe <>,
	Arnd Bergmann <>,
	Greg Kroah-Hartman <>,,
Subject: Re: [PATCH v2] tpm: Switch to platform_get_irq_optional()
Date: Mon, 28 Oct 2019 22:47:53 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Oct 25, 2019 at 11:14:48AM +0200, Hans de Goede wrote:
> platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
> tpm_tis driver is optional, this is undesirable.
> Specifically this leads to this new false-positive error being logged:
> [    5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
> This commit switches to platform_get_irq_optional(), which does not log
> an error, fixing this.
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"
> Cc: <> # 5.4.x
> Signed-off-by: Hans de Goede <>

Reviewed-by: Jarkko Sakkinen <>


      parent reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  9:14 Hans de Goede
2019-10-25 14:12 ` Jerry Snitselaar
2019-10-28 20:47 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on

Archives are clonable:
	git clone --mirror linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ \
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone