From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] tpm: Add major_version sysfs file
Date: Tue, 29 Oct 2019 11:17:31 +0200 [thread overview]
Message-ID: <20191029091731.GC9896@linux.intel.com> (raw)
In-Reply-To: <20191028210507.7i6d6b5olw72shm3@cantor>
On Mon, Oct 28, 2019 at 02:05:07PM -0700, Jerry Snitselaar wrote:
> On Mon Oct 28 19, Jarkko Sakkinen wrote:
> > On Fri, Oct 25, 2019 at 12:31:03PM -0700, Jerry Snitselaar wrote:
> > > + return sprintf(buf, "%s\n", chip->flags & TPM_CHIP_FLAG_TPM2
> > > + ? "2.0" : "1.2");
> >
> > This is not right. Should be either "1" or "2".
> >
> > /Jarkko
>
> Okay I will fix that up. Do we have a final decision on the file name,
> major_version versus version_major?
Well, I don't see how major_version would make any sense. It is
not as future proof as version_major. Still waiting for Jason's
feedback for this.
/Jarkko
next prev parent reply other threads:[~2019-10-29 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 19:31 [PATCH v2] tpm: Add major_version sysfs file Jerry Snitselaar
2019-10-28 20:53 ` Jarkko Sakkinen
2019-10-28 21:05 ` Jerry Snitselaar
2019-10-29 9:17 ` Jarkko Sakkinen [this message]
2019-10-29 12:43 ` Jason Gunthorpe
2019-10-29 14:22 ` Jarkko Sakkinen
2019-10-29 14:56 ` James Bottomley
2019-10-29 15:22 ` Jason Gunthorpe
2019-10-29 19:11 ` Jerry Snitselaar
2019-10-31 21:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029091731.GC9896@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).