From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6EFBC33CB2 for ; Wed, 29 Jan 2020 08:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B510020708 for ; Wed, 29 Jan 2020 08:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgA2Iai (ORCPT ); Wed, 29 Jan 2020 03:30:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:38582 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgA2Iai (ORCPT ); Wed, 29 Jan 2020 03:30:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 74626B00A; Wed, 29 Jan 2020 08:30:36 +0000 (UTC) Date: Wed, 29 Jan 2020 09:30:34 +0100 From: Petr Vorel To: Mimi Zohar Cc: Jerry Snitselaar , linux-integrity@vger.kernel.org, James Bottomley , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ima: use the IMA configured hash algo to calculate the boot aggregate Message-ID: <20200129083034.GA387@dell5510> Reply-To: Petr Vorel References: <1580140919-6127-1-git-send-email-zohar@linux.ibm.com> <20200127204941.2ewman4y5nzvkjqe@cantor> <1580160699.5088.64.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1580160699.5088.64.camel@linux.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Mimi, Reviewed-by: Petr Vorel > The original LTP ima_boot_aggregate.c test needed to be updated to > support TPM 2.0 before this change.  For TPM 2.0, the PCRs are not > exported.  With this change, the kernel could be reading PCRs from a > TPM bank other than SHA1 and calculating the boot_aggregate based on a > different hash algorithm as well.  I'm not sure how a remote verifier > would know which TPM bank was read, when calculating the boot- > aggregate. Mimi, do you plan to do update LTP test? Kind regards, Petr