From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Fabien Lahoudere <fabien.lahoudere@collabora.com>
Cc: swboyd@chromium.org, kernel@collabora.com,
Duncan Laurie <dlaurie@chromium.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/1] Add TPM 2.0 compatible I2C interface for chips with cr50 firmware.
Date: Tue, 25 Feb 2020 13:47:28 +0200 [thread overview]
Message-ID: <20200225114728.GA15662@linux.intel.com> (raw)
In-Reply-To: <20200225110810.1321686-1-fabien.lahoudere@collabora.com>
On Tue, Feb 25, 2020 at 12:08:07PM +0100, Fabien Lahoudere wrote:
> The firmware running on the currently supported H1 MCU requires a
> special driver to handle its specific protocol, and this makes it
> unsuitable to use tpm_tis_core_* and instead it must implement the
> underlying TPM protocol similar to the other I2C TPM drivers.
>
> - All 4 byes of status register must be read/written at once.
> - FIFO and burst count is limited to 63 and must be drained by AP.
> - Provides an interrupt to indicate when read response data is ready
> and when the TPM is finished processing write data.
>
> This driver is based on the existing infineon I2C TPM driver, which
> most closely matches the cr50 i2c protocol behavior. The driver is
> intentionally kept very similar in structure and style to the
> corresponding drivers in coreboot and depthcharge.
>
> Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
> [swboyd@chromium.org: Depend on i2c even if it's a module, replace
> boilier plate with SPDX tag, drop asm/byteorder.h include, simplify
> return from probe]
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.com>
The code quality looks overally decent, checkpatch.pl does not complain
and neither does sparse.
My only concern is the lack of tested-by's.
/Jarkko
prev parent reply other threads:[~2020-02-25 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 11:08 [PATCH 1/1] Add TPM 2.0 compatible I2C interface for chips with cr50 firmware Fabien Lahoudere
2020-02-25 11:47 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225114728.GA15662@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=fabien.lahoudere@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=kernel@collabora.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).