From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4965FC35E01 for ; Tue, 25 Feb 2020 16:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21BF02082F for ; Tue, 25 Feb 2020 16:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730650AbgBYQ5t (ORCPT ); Tue, 25 Feb 2020 11:57:49 -0500 Received: from mga09.intel.com ([134.134.136.24]:17264 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbgBYQ5t (ORCPT ); Tue, 25 Feb 2020 11:57:49 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 08:57:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,484,1574150400"; d="scan'208";a="438125640" Received: from gbwalsh-mobl6.ger.corp.intel.com (HELO localhost) ([10.252.26.72]) by fmsmga006.fm.intel.com with ESMTP; 25 Feb 2020 08:57:45 -0800 Date: Tue, 25 Feb 2020 18:57:44 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-integrity@vger.kernel.org, aik@ozlabs.ru, david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org, nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca, Stefan Berger Subject: Re: [PATCH v2 2/4] tpm: ibmvtpm: Wait for buffer to be set before proceeding Message-ID: <20200225165744.GD15662@linux.intel.com> References: <20200213202329.898607-1-stefanb@linux.vnet.ibm.com> <20200213202329.898607-3-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200213202329.898607-3-stefanb@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Feb 13, 2020 at 03:23:27PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Synchronize with the results from the CRQs before continuing with > the initialization. This avoids trying to send TPM commands while > the rtce buffer has not been allocated, yet. What is CRQ anyway an acronym of? > This patch fixes an existing race condition that may occurr if the > hypervisor does not quickly respond to the VTPM_GET_RTCE_BUFFER_SIZE > request sent during initialization and therefore the ibmvtpm->rtce_buf > has not been allocated at the time the first TPM command is sent. If it fixes a race condition, why doesn't it have a fixes tag? /Jarkko