Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation
@ 2020-03-05 20:30 Lukas Bulwahn
  2020-03-06  5:03 ` Sumit Garg
  2020-03-06 19:31 ` Jarkko Sakkinen
  0 siblings, 2 replies; 5+ messages in thread
From: Lukas Bulwahn @ 2020-03-05 20:30 UTC (permalink / raw)
  To: Sumit Garg, James Bottomley, Jarkko Sakkinen, Mimi Zohar
  Cc: linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

  warning: no file matches F: security/keys/trusted.c
  warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
files in security/keys/trusted-keys/ are identified as part of
KEYS-TRUSTED.

Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Changes to v1:
  - use a global pattern for matching the whole security/keys/trusted-keys/
    directory.
Changes to v2:
  - name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5c755e03ddee..7f11ac752b91 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9276,8 +9276,8 @@ L:	keyrings@vger.kernel.org
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
-F:	security/keys/trusted.c
-F:	include/keys/trusted.h
+F:	include/keys/trusted_tpm.h
+F:	security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:	David Howells <dhowells@redhat.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05 20:30 [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
@ 2020-03-06  5:03 ` Sumit Garg
  2020-03-06 19:31 ` Jarkko Sakkinen
  1 sibling, 0 replies; 5+ messages in thread
From: Sumit Garg @ 2020-03-06  5:03 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: James Bottomley, Jarkko Sakkinen, Mimi Zohar, linux-integrity,
	open list:ASYMMETRIC KEYS, Sebastian Duda, Joe Perches,
	kernel-janitors, Linux Kernel Mailing List

On Fri, 6 Mar 2020 at 02:00, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
>   warning: no file matches F: security/keys/trusted.c
>   warning: no file matches F: include/keys/trusted.h
>
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> files in security/keys/trusted-keys/ are identified as part of
> KEYS-TRUSTED.
>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Sumit Garg <sumit.garg@linaro.org>

> ---
> Changes to v1:
>   - use a global pattern for matching the whole security/keys/trusted-keys/
>     directory.
> Changes to v2:
>   - name the correct directory in the commit message
>
> Sumit, please ack.
> Jarkko, please pick this patch v3.
>
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c755e03ddee..7f11ac752b91 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9276,8 +9276,8 @@ L:        keyrings@vger.kernel.org
>  S:     Supported
>  F:     Documentation/security/keys/trusted-encrypted.rst
>  F:     include/keys/trusted-type.h
> -F:     security/keys/trusted.c
> -F:     include/keys/trusted.h
> +F:     include/keys/trusted_tpm.h
> +F:     security/keys/trusted-keys/
>
>  KEYS/KEYRINGS
>  M:     David Howells <dhowells@redhat.com>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05 20:30 [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
  2020-03-06  5:03 ` Sumit Garg
@ 2020-03-06 19:31 ` Jarkko Sakkinen
  2020-03-06 20:50   ` Lukas Bulwahn
  1 sibling, 1 reply; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-03-06 19:31 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Sumit Garg, James Bottomley, Mimi Zohar, linux-integrity,
	keyrings, Sebastian Duda, Joe Perches, kernel-janitors,
	linux-kernel

On Thu, Mar 05, 2020 at 09:30:13PM +0100, Lukas Bulwahn wrote:
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: security/keys/trusted.c
>   warning: no file matches F: include/keys/trusted.h
> 
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> files in security/keys/trusted-keys/ are identified as part of
> KEYS-TRUSTED.
> 
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

> Changes to v1:
>   - use a global pattern for matching the whole security/keys/trusted-keys/
>     directory.
> Changes to v2:
>   - name the correct directory in the commit message
> 
> Sumit, please ack.
> Jarkko, please pick this patch v3.

Please tell me why you emphasize the moment when a patch that does not
fix a critical bug is picked?

Do you have systems that break because the MAINTAINERS file is not
updated?

It will end up in v5.7 PR for sure but saying things like that is same
as saying that there would be some catastrophically urgent need to still
squeeze the patch into v5.6. Unless you actually have something critical
in your hand, please stop doing that.

/Jarkko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-06 19:31 ` Jarkko Sakkinen
@ 2020-03-06 20:50   ` Lukas Bulwahn
  2020-03-06 22:40     ` Jarkko Sakkinen
  0 siblings, 1 reply; 5+ messages in thread
From: Lukas Bulwahn @ 2020-03-06 20:50 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Lukas Bulwahn, Sumit Garg, James Bottomley, Mimi Zohar,
	linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel



On Fri, 6 Mar 2020, Jarkko Sakkinen wrote:

> On Thu, Mar 05, 2020 at 09:30:13PM +0100, Lukas Bulwahn wrote:
> > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> > renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> > to trusted-keys/trusted_tpm1.c in security/keys/.
> > 
> > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > 
> >   warning: no file matches F: security/keys/trusted.c
> >   warning: no file matches F: include/keys/trusted.h
> > 
> > Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> > files in security/keys/trusted-keys/ are identified as part of
> > KEYS-TRUSTED.
> > 
> > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> > Changes to v1:
> >   - use a global pattern for matching the whole security/keys/trusted-keys/
> >     directory.
> > Changes to v2:
> >   - name the correct directory in the commit message
> > 
> > Sumit, please ack.
> > Jarkko, please pick this patch v3.
> 
> Please tell me why you emphasize the moment when a patch that does not
> fix a critical bug is picked?
> 
> Do you have systems that break because the MAINTAINERS file is not
> updated?
> 
> It will end up in v5.7 PR for sure but saying things like that is same
> as saying that there would be some catastrophically urgent need to still
> squeeze the patch into v5.6. Unless you actually have something critical
> in your hand, please stop doing that.
> 

Got it. I did not intend to emphasize any urgency; I will not continue 
to do that for patches of this clean-up type.

Lukas

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-06 20:50   ` Lukas Bulwahn
@ 2020-03-06 22:40     ` Jarkko Sakkinen
  0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-03-06 22:40 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Sumit Garg, James Bottomley, Mimi Zohar, linux-integrity,
	keyrings, Sebastian Duda, Joe Perches, kernel-janitors,
	linux-kernel

On Fri, Mar 06, 2020 at 09:50:44PM +0100, Lukas Bulwahn wrote:
> 
> 
> On Fri, 6 Mar 2020, Jarkko Sakkinen wrote:
> 
> > On Thu, Mar 05, 2020 at 09:30:13PM +0100, Lukas Bulwahn wrote:
> > > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> > > renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> > > to trusted-keys/trusted_tpm1.c in security/keys/.
> > > 
> > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > 
> > >   warning: no file matches F: security/keys/trusted.c
> > >   warning: no file matches F: include/keys/trusted.h
> > > 
> > > Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all
> > > files in security/keys/trusted-keys/ are identified as part of
> > > KEYS-TRUSTED.
> > > 
> > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > > Changes to v1:
> > >   - use a global pattern for matching the whole security/keys/trusted-keys/
> > >     directory.
> > > Changes to v2:
> > >   - name the correct directory in the commit message
> > > 
> > > Sumit, please ack.
> > > Jarkko, please pick this patch v3.
> > 
> > Please tell me why you emphasize the moment when a patch that does not
> > fix a critical bug is picked?
> > 
> > Do you have systems that break because the MAINTAINERS file is not
> > updated?
> > 
> > It will end up in v5.7 PR for sure but saying things like that is same
> > as saying that there would be some catastrophically urgent need to still
> > squeeze the patch into v5.6. Unless you actually have something critical
> > in your hand, please stop doing that.
> > 
> 
> Got it. I did not intend to emphasize any urgency; I will not continue 
> to do that for patches of this clean-up type.

Anyway, thank you and I've applied your patch and will include it to my
v5.7 PR.

/Jarkko

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 20:30 [PATCH v3] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
2020-03-06  5:03 ` Sumit Garg
2020-03-06 19:31 ` Jarkko Sakkinen
2020-03-06 20:50   ` Lukas Bulwahn
2020-03-06 22:40     ` Jarkko Sakkinen

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git