* [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module @ 2020-03-17 13:08 Stefan Berger 2020-03-17 15:22 ` Sachin Sant 2020-03-18 19:42 ` Jarkko Sakkinen 0 siblings, 2 replies; 8+ messages in thread From: Stefan Berger @ 2020-03-17 13:08 UTC (permalink / raw) To: jarkko.sakkinen, linux-integrity Cc: linux-kernel, linux-next, linuxppc-dev, sachinp, mpe, Stefan Berger From: Stefan Berger <stefanb@linux.ibm.com> This patch fixes the following problem when the ibmvtpm driver is built as a module: ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 make: *** [Makefile:1298: modules] Error 2 Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> --- drivers/char/tpm/tpm2-cmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c index 76f67b155bd5..eff1f12d981a 100644 --- a/drivers/char/tpm/tpm2-cmd.c +++ b/drivers/char/tpm/tpm2-cmd.c @@ -681,6 +681,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip) rc = -ENODEV; return rc; } +EXPORT_SYMBOL_GPL(tpm2_get_cc_attrs_tbl); /** * tpm2_startup - turn on the TPM -- 2.23.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-17 13:08 [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger @ 2020-03-17 15:22 ` Sachin Sant 2020-03-17 15:30 ` Stefan Berger 2020-03-18 19:42 ` Jarkko Sakkinen 1 sibling, 1 reply; 8+ messages in thread From: Sachin Sant @ 2020-03-17 15:22 UTC (permalink / raw) To: Stefan Berger Cc: jarkko.sakkinen, linux-integrity, LKML, Linux Next Mailing List, linuxppc-dev, mpe, Stefan Berger > On 17-Mar-2020, at 6:38 PM, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote: > > From: Stefan Berger <stefanb@linux.ibm.com> > > This patch fixes the following problem when the ibmvtpm driver > is built as a module: > > ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > make: *** [Makefile:1298: modules] Error 2 > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Thanks -Sachin ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-17 15:22 ` Sachin Sant @ 2020-03-17 15:30 ` Stefan Berger 0 siblings, 0 replies; 8+ messages in thread From: Stefan Berger @ 2020-03-17 15:30 UTC (permalink / raw) To: Sachin Sant, Stefan Berger Cc: jarkko.sakkinen, linux-integrity, LKML, Linux Next Mailing List, linuxppc-dev, mpe On 3/17/20 11:22 AM, Sachin Sant wrote: >> On 17-Mar-2020, at 6:38 PM, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote: >> >> From: Stefan Berger <stefanb@linux.ibm.com> >> >> This patch fixes the following problem when the ibmvtpm driver >> is built as a module: >> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 >> make: *** [Makefile:1298: modules] Error 2 >> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> > Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Thank you! Stefan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-17 13:08 [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger 2020-03-17 15:22 ` Sachin Sant @ 2020-03-18 19:42 ` Jarkko Sakkinen 2020-03-18 19:53 ` Stefan Berger 1 sibling, 1 reply; 8+ messages in thread From: Jarkko Sakkinen @ 2020-03-18 19:42 UTC (permalink / raw) To: Stefan Berger Cc: linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp, mpe, Stefan Berger On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: > From: Stefan Berger <stefanb@linux.ibm.com> > > This patch fixes the following problem when the ibmvtpm driver > is built as a module: > > ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > make: *** [Makefile:1298: modules] Error 2 > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. Thanks. /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-18 19:42 ` Jarkko Sakkinen @ 2020-03-18 19:53 ` Stefan Berger 2020-03-19 14:27 ` Jarkko Sakkinen 0 siblings, 1 reply; 8+ messages in thread From: Stefan Berger @ 2020-03-18 19:53 UTC (permalink / raw) To: Jarkko Sakkinen, Stefan Berger Cc: linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp, mpe On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: > On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: >> From: Stefan Berger <stefanb@linux.ibm.com> >> >> This patch fixes the following problem when the ibmvtpm driver >> is built as a module: >> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 >> make: *** [Makefile:1298: modules] Error 2 >> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. > Thanks. I did not add the fixes tag because I do not know the final commit hash, or is it the final commit hash once it is in linux-next? I doubt it with all the merging that can occur. Stefan > > /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-18 19:53 ` Stefan Berger @ 2020-03-19 14:27 ` Jarkko Sakkinen 2020-03-19 15:56 ` Stefan Berger 0 siblings, 1 reply; 8+ messages in thread From: Jarkko Sakkinen @ 2020-03-19 14:27 UTC (permalink / raw) To: Stefan Berger Cc: Stefan Berger, linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp, mpe On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote: > On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: > > On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: > > > From: Stefan Berger <stefanb@linux.ibm.com> > > > > > > This patch fixes the following problem when the ibmvtpm driver > > > is built as a module: > > > > > > ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > > > make: *** [Makefile:1298: modules] Error 2 > > > > > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > > Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. > > Thanks. > > I did not add the fixes tag because I do not know the final commit hash, or > is it the final commit hash once it is in linux-next? I doubt it with all > the merging that can occur. Can you send me a new version after rc1 is out? /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-19 14:27 ` Jarkko Sakkinen @ 2020-03-19 15:56 ` Stefan Berger 2020-03-19 21:16 ` Jarkko Sakkinen 0 siblings, 1 reply; 8+ messages in thread From: Stefan Berger @ 2020-03-19 15:56 UTC (permalink / raw) To: Jarkko Sakkinen Cc: Stefan Berger, linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp, mpe On 3/19/20 10:27 AM, Jarkko Sakkinen wrote: > On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote: >> On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: >>> On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: >>>> From: Stefan Berger <stefanb@linux.ibm.com> >>>> >>>> This patch fixes the following problem when the ibmvtpm driver >>>> is built as a module: >>>> >>>> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! >>>> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 >>>> make: *** [Makefile:1298: modules] Error 2 >>>> >>>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> >>> Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. >>> Thanks. >> I did not add the fixes tag because I do not know the final commit hash, or >> is it the final commit hash once it is in linux-next? I doubt it with all >> the merging that can occur. > Can you send me a new version after rc1 is out? Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once the bad patch is in linux-next. So I reposted yesterday (with a stray 'q' in the title :-( ): https://lkml.org/lkml/2020/3/18/1283 Stefan > > /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module 2020-03-19 15:56 ` Stefan Berger @ 2020-03-19 21:16 ` Jarkko Sakkinen 0 siblings, 0 replies; 8+ messages in thread From: Jarkko Sakkinen @ 2020-03-19 21:16 UTC (permalink / raw) To: Stefan Berger Cc: Stefan Berger, linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp, mpe On Thu, Mar 19, 2020 at 11:56:11AM -0400, Stefan Berger wrote: > On 3/19/20 10:27 AM, Jarkko Sakkinen wrote: > > On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote: > > > On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: > > > > On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: > > > > > From: Stefan Berger <stefanb@linux.ibm.com> > > > > > > > > > > This patch fixes the following problem when the ibmvtpm driver > > > > > is built as a module: > > > > > > > > > > ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! > > > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > > > > > make: *** [Makefile:1298: modules] Error 2 > > > > > > > > > > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > > > > Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. > > > > Thanks. > > > I did not add the fixes tag because I do not know the final commit hash, or > > > is it the final commit hash once it is in linux-next? I doubt it with all > > > the merging that can occur. > > Can you send me a new version after rc1 is out? > > Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once the > bad patch is in linux-next. So I reposted yesterday (with a stray 'q' in the > title :-( ): OK, cool, I'll correct it and apply thanks. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-19 21:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-17 13:08 [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger 2020-03-17 15:22 ` Sachin Sant 2020-03-17 15:30 ` Stefan Berger 2020-03-18 19:42 ` Jarkko Sakkinen 2020-03-18 19:53 ` Stefan Berger 2020-03-19 14:27 ` Jarkko Sakkinen 2020-03-19 15:56 ` Stefan Berger 2020-03-19 21:16 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).