From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Hans de Goede <hdegoede@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Stefan Berger <stefanb@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Disable broken IRQ handling code
Date: Sat, 11 Apr 2020 00:12:25 +0300 [thread overview]
Message-ID: <20200410211225.GA75170@linux.intel.com> (raw)
In-Reply-To: <20200410163826.GM11886@ziepe.ca>
On Fri, Apr 10, 2020 at 01:38:26PM -0300, Jason Gunthorpe wrote:
> On Thu, Apr 09, 2020 at 11:10:44PM +0200, Hans de Goede wrote:
> > Since commit dda8b2af395b ("tpm: Revert "tpm_tis_core: Set
> > TPM_CHIP_FLAG_IRQ before probing for interrupts"") we no longer set
> > the TPM_CHIP_FLAG_IRQ ever.
>
> This all used to work..
>
> > So the whole IRQ probing code is not useful, worse we rely on the
> > IRQ-test path of tpm_tis_send() to call disable_interrupts() if
> > interrupts do not work, but that path never gets entered because we
> > never set the TPM_CHIP_FLAG_IRQ.
>
> The IRQ probing code should be deleted.
>
> > On some systems, e.g. the Lenovo X1 8th gen, the interrupt we try
> > to use and never free creates an interrupt storm followed by
> > an "irq XX: nobody cared" oops.
>
> Is this related to probing?
Found it:
https://bugzilla.kernel.org/show_bug.cgi?id=203561
Has existed for a quite a while.
/Jarkko
next prev parent reply other threads:[~2020-04-10 21:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 21:10 [PATCH] tpm_tis_core: Disable broken IRQ handling code Hans de Goede
2020-04-10 16:38 ` Jason Gunthorpe
2020-04-10 21:08 ` Jarkko Sakkinen
2020-04-10 21:12 ` Jarkko Sakkinen [this message]
2020-04-14 17:44 ` Jerry Snitselaar
2020-04-15 8:57 ` Jan Lübbe
2020-04-16 17:03 ` Jarkko Sakkinen
2020-04-10 21:06 ` Jarkko Sakkinen
2020-04-10 21:09 ` Jarkko Sakkinen
2020-04-12 14:55 ` Jarkko Sakkinen
2020-05-07 14:02 ` Hans de Goede
2020-05-07 14:02 ` Hans de Goede
2020-05-07 14:17 ` Jerry Snitselaar
2020-05-07 17:38 ` Hans de Goede
2020-05-07 21:51 ` Dan Williams
2020-05-07 23:13 ` Jerry Snitselaar
2020-05-08 7:45 ` Hans de Goede
2020-05-13 21:31 ` Jarkko Sakkinen
2020-06-04 9:17 ` Jerry Snitselaar
2020-06-15 22:06 ` Jarkko Sakkinen
2020-06-16 8:24 ` Hans de Goede
2020-06-17 22:56 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410211225.GA75170@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).