linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: shuah <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org,
	Nikita Sobolev <Nikita.Sobolev@synopsys.com>,
	Tadeusz Struk <tadeusz.struk@intel.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "Kernel selftests: tpm2: check for tpm support"
Date: Thu, 16 Apr 2020 20:01:08 +0300	[thread overview]
Message-ID: <20200416170108.GB199110@linux.intel.com> (raw)
In-Reply-To: <ac896427-581d-6fd0-e088-3bc519b6ed66@kernel.org>

On Tue, Apr 14, 2020 at 02:52:12PM -0600, shuah wrote:
> On 4/14/20 1:38 PM, Jarkko Sakkinen wrote:
> > On Tue, Apr 14, 2020 at 10:37:25PM +0300, Jarkko Sakkinen wrote:
> > > On Tue, Apr 14, 2020 at 09:12:05AM -0600, shuah wrote:
> > > > On 4/12/20 8:23 AM, Jarkko Sakkinen wrote:
> > > > > This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.
> > > > > 
> > > > > The original comment
> > > > 
> > > > commit I assume.
> > > > 
> > > >   was neither reviewed nor tested. Thus, this the
> > > > > *only* possible action to take.
> > > > > 
> > > > 
> > > > Bummer. I will apply this right away.
> > > 
> > > No worries, and fine with the change as long as I'm able to
> > > review and try it out :-) Sorry for the dull tone!
> > 
> 
> I usually wait for test authors to do the review. This patch
> was sent a while back and I ended up picking it up. It stayed
> in next for a while. It is fixed now.
> 
> > I mean refined change after this revert has been applied.
> > 
> Of course. I applied your revert to for my next pull request
> to linux-kselftest next
> 
> thanks,
> -- Shuah

Thanks.

/Jarkko

      reply	other threads:[~2020-04-16 17:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12 14:23 [PATCH] Revert "Kernel selftests: tpm2: check for tpm support" Jarkko Sakkinen
2020-04-14 15:12 ` shuah
2020-04-14 19:37   ` Jarkko Sakkinen
2020-04-14 19:38     ` Jarkko Sakkinen
2020-04-14 20:52       ` shuah
2020-04-16 17:01         ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416170108.GB199110@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=Nikita.Sobolev@synopsys.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tadeusz.struk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).