Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] make implementation of read16, read32 and write32 optional fix
@ 2020-05-14 16:48 amirmizi6
  2020-05-14 16:48 ` [PATCH v1] tpm: tpm_tis: " amirmizi6
  0 siblings, 1 reply; 2+ messages in thread
From: amirmizi6 @ 2020-05-14 16:48 UTC (permalink / raw)
  To: Eyal.Cohen, jarkko.sakkinen, oshrialkoby85, alexander.steffen,
	robh+dt, benoit.houyere@st.com--to=mark.rutland, peterhuewe,
	christophe-h.richard, jgg, arnd, gregkh
  Cc: devicetree, linux-kernel, linux-integrity, oshri.alkoby,
	tmaimon77, gcwilson, kgoldman, Dan.Morav, oren.tanami,
	shmulik.hager, amir.mizinski, Amir Mizinski

From: Amir Mizinski <amirmizi6@gmail.com>

This patch fix compilation error for newly added CR50 SPI driver found in previous submission.

Amir Mizinski (1):
  tpm: tpm_tis: make implementation of read16, read32 and write32
    optional fix

 drivers/char/tpm/tpm_tis_spi.h      | 4 ----
 drivers/char/tpm/tpm_tis_spi_cr50.c | 3 ---
 2 files changed, 7 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v1] tpm: tpm_tis: make implementation of read16, read32 and write32 optional fix
  2020-05-14 16:48 [PATCH v1] make implementation of read16, read32 and write32 optional fix amirmizi6
@ 2020-05-14 16:48 ` amirmizi6
  0 siblings, 0 replies; 2+ messages in thread
From: amirmizi6 @ 2020-05-14 16:48 UTC (permalink / raw)
  To: Eyal.Cohen, jarkko.sakkinen, oshrialkoby85, alexander.steffen,
	robh+dt, benoit.houyere@st.com--to=mark.rutland, peterhuewe,
	christophe-h.richard, jgg, arnd, gregkh
  Cc: devicetree, linux-kernel, linux-integrity, oshri.alkoby,
	tmaimon77, gcwilson, kgoldman, Dan.Morav, oren.tanami,
	shmulik.hager, amir.mizinski, Amir Mizinski, kbuild test robot

From: Amir Mizinski <amirmizi6@gmail.com>

Removed SPI extern function definitions and unused callback functions for
CR50 driver.

Fixes: fa05dc792ea0 ("tpm: tpm_tis: make implementation of read16, read32 and write32 optional")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
---
 drivers/char/tpm/tpm_tis_spi.h      | 4 ----
 drivers/char/tpm/tpm_tis_spi_cr50.c | 3 ---
 2 files changed, 7 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis_spi.h b/drivers/char/tpm/tpm_tis_spi.h
index bba7397..d0f66f6 100644
--- a/drivers/char/tpm/tpm_tis_spi.h
+++ b/drivers/char/tpm/tpm_tis_spi.h
@@ -31,10 +31,6 @@ extern int tpm_tis_spi_init(struct spi_device *spi, struct tpm_tis_spi_phy *phy,
 extern int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 				u8 *in, const u8 *out);
 
-extern int tpm_tis_spi_read16(struct tpm_tis_data *data, u32 addr, u16 *result);
-extern int tpm_tis_spi_read32(struct tpm_tis_data *data, u32 addr, u32 *result);
-extern int tpm_tis_spi_write32(struct tpm_tis_data *data, u32 addr, u32 value);
-
 #ifdef CONFIG_TCG_TIS_SPI_CR50
 extern int cr50_spi_probe(struct spi_device *spi);
 #else
diff --git a/drivers/char/tpm/tpm_tis_spi_cr50.c b/drivers/char/tpm/tpm_tis_spi_cr50.c
index 37d72e8..f339d20 100644
--- a/drivers/char/tpm/tpm_tis_spi_cr50.c
+++ b/drivers/char/tpm/tpm_tis_spi_cr50.c
@@ -215,9 +215,6 @@ static int tpm_tis_spi_cr50_write_bytes(struct tpm_tis_data *data, u32 addr,
 static const struct tpm_tis_phy_ops tpm_spi_cr50_phy_ops = {
 	.read_bytes = tpm_tis_spi_cr50_read_bytes,
 	.write_bytes = tpm_tis_spi_cr50_write_bytes,
-	.read16 = tpm_tis_spi_read16,
-	.read32 = tpm_tis_spi_read32,
-	.write32 = tpm_tis_spi_write32,
 };
 
 static void cr50_print_fw_version(struct tpm_tis_data *data)
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 16:48 [PATCH v1] make implementation of read16, read32 and write32 optional fix amirmizi6
2020-05-14 16:48 ` [PATCH v1] tpm: tpm_tis: " amirmizi6

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git