Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] Kernel selftests: Add check if TPM devices are supported
@ 2020-05-21 14:43 Nikita Sobolev
  2020-05-22 16:37 ` Jarkko Sakkinen
  2020-05-22 19:07 ` Petr Vorel
  0 siblings, 2 replies; 6+ messages in thread
From: Nikita Sobolev @ 2020-05-21 14:43 UTC (permalink / raw)
  To: Shuah Khan, linux-kselftest
  Cc: Jarkko Sakkinen, Tadeusz Struk, Joey Pabalinas, Petr Vorel,
	linux-kernel, linux-integrity, Jason Gunthorpe, Peter Huewe,
	Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc, Nikita Sobolev

TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
are available. In case, when these devices are not available test
fails, but expected behaviour is skipped test.

Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
---
Changes for v2:
    - Coding Style cleanup

Changes for v3:
    - Commit text message cleanup

 tools/testing/selftests/tpm2/test_smoke.sh | 5 +++++
 tools/testing/selftests/tpm2/test_space.sh | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh
index 8155c2ea7ccb..663062701d5a 100755
--- a/tools/testing/selftests/tpm2/test_smoke.sh
+++ b/tools/testing/selftests/tpm2/test_smoke.sh
@@ -1,6 +1,11 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+[ -f /dev/tpm0 ] || exit $ksft_skip
+
 python -m unittest -v tpm2_tests.SmokeTest
 python -m unittest -v tpm2_tests.AsyncTest
 
diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh
index a6f5e346635e..36c9d030a1c6 100755
--- a/tools/testing/selftests/tpm2/test_space.sh
+++ b/tools/testing/selftests/tpm2/test_space.sh
@@ -1,4 +1,9 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+[ -f /dev/tpmrm0 ] || exit $ksft_skip
+
 python -m unittest -v tpm2_tests.SpaceTest
-- 
2.16.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported
  2020-05-21 14:43 [PATCH v3] Kernel selftests: Add check if TPM devices are supported Nikita Sobolev
@ 2020-05-22 16:37 ` Jarkko Sakkinen
  2020-05-22 16:37   ` Jarkko Sakkinen
  2020-05-22 19:07 ` Petr Vorel
  1 sibling, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-05-22 16:37 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Tadeusz Struk, Joey Pabalinas,
	Petr Vorel, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc

On Thu, May 21, 2020 at 05:43:44PM +0300, Nikita Sobolev wrote:
> TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> are available. In case, when these devices are not available test
> fails, but expected behaviour is skipped test.
> 
> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Thank you.

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported
  2020-05-22 16:37 ` Jarkko Sakkinen
@ 2020-05-22 16:37   ` Jarkko Sakkinen
  2020-05-22 19:23     ` shuah
  0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-05-22 16:37 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Tadeusz Struk, Joey Pabalinas,
	Petr Vorel, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc

On Fri, May 22, 2020 at 07:37:17PM +0300, Jarkko Sakkinen wrote:
> On Thu, May 21, 2020 at 05:43:44PM +0300, Nikita Sobolev wrote:
> > TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> > are available. In case, when these devices are not available test
> > fails, but expected behaviour is skipped test.
> > 
> > Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Shuah, can you pick this up?

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported
  2020-05-21 14:43 [PATCH v3] Kernel selftests: Add check if TPM devices are supported Nikita Sobolev
  2020-05-22 16:37 ` Jarkko Sakkinen
@ 2020-05-22 19:07 ` Petr Vorel
  1 sibling, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2020-05-22 19:07 UTC (permalink / raw)
  To: Nikita Sobolev
  Cc: Shuah Khan, linux-kselftest, Jarkko Sakkinen, Tadeusz Struk,
	Joey Pabalinas, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc

Hi,

> TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> are available. In case, when these devices are not available test
> fails, but expected behaviour is skipped test.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported
  2020-05-22 16:37   ` Jarkko Sakkinen
@ 2020-05-22 19:23     ` shuah
  2020-05-22 20:00       ` Jarkko Sakkinen
  0 siblings, 1 reply; 6+ messages in thread
From: shuah @ 2020-05-22 19:23 UTC (permalink / raw)
  To: Jarkko Sakkinen, Nikita Sobolev
  Cc: linux-kselftest, Tadeusz Struk, Joey Pabalinas, Petr Vorel,
	linux-kernel, linux-integrity, Jason Gunthorpe, Peter Huewe,
	Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc, shuah

On 5/22/20 10:37 AM, Jarkko Sakkinen wrote:
> On Fri, May 22, 2020 at 07:37:17PM +0300, Jarkko Sakkinen wrote:
>> On Thu, May 21, 2020 at 05:43:44PM +0300, Nikita Sobolev wrote:
>>> TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
>>> are available. In case, when these devices are not available test
>>> fails, but expected behaviour is skipped test.
>>>
>>> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
>>
>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Shuah, can you pick this up?
> 
> /Jarkko
> 

Done. Applied to linux-kselftest next for Linux 5.8-rc1.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported
  2020-05-22 19:23     ` shuah
@ 2020-05-22 20:00       ` Jarkko Sakkinen
  0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-05-22 20:00 UTC (permalink / raw)
  To: shuah
  Cc: Nikita Sobolev, linux-kselftest, Tadeusz Struk, Joey Pabalinas,
	Petr Vorel, linux-kernel, linux-integrity, Jason Gunthorpe,
	Peter Huewe, Alexey Brodkin, Eugeniy Paltsev, linux-snps-arc

On Fri, May 22, 2020 at 01:23:26PM -0600, shuah wrote:
> On 5/22/20 10:37 AM, Jarkko Sakkinen wrote:
> > On Fri, May 22, 2020 at 07:37:17PM +0300, Jarkko Sakkinen wrote:
> > > On Thu, May 21, 2020 at 05:43:44PM +0300, Nikita Sobolev wrote:
> > > > TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they
> > > > are available. In case, when these devices are not available test
> > > > fails, but expected behaviour is skipped test.
> > > > 
> > > > Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
> > > 
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > Shuah, can you pick this up?
> > 
> > /Jarkko
> > 
> 
> Done. Applied to linux-kselftest next for Linux 5.8-rc1.
> 
> thanks,
> -- Shuah

Thank you.

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 14:43 [PATCH v3] Kernel selftests: Add check if TPM devices are supported Nikita Sobolev
2020-05-22 16:37 ` Jarkko Sakkinen
2020-05-22 16:37   ` Jarkko Sakkinen
2020-05-22 19:23     ` shuah
2020-05-22 20:00       ` Jarkko Sakkinen
2020-05-22 19:07 ` Petr Vorel

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git