linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: amirmizi6@gmail.com
Cc: Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com,
	alexander.steffen@infineon.com, robh+dt@kernel.org,
	peterhuewe@gmx.de, christophe-h.richard@st.com, jgg@ziepe.ca,
	arnd@arndb.de, gregkh@linuxfoundation.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
	tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
	Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
	shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com,
	Christophe Ricard <christophe-h.ricard@st.com>
Subject: Re: [PATCH v10 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure.
Date: Wed, 17 Jun 2020 04:17:13 +0300	[thread overview]
Message-ID: <20200617011713.GC5100@linux.intel.com> (raw)
In-Reply-To: <20200604134713.157951-4-amirmizi6@gmail.com>

On Thu, Jun 04, 2020 at 04:47:08PM +0300, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
> 
> The FIFO protocol described in the TCG PC Client Device Driver Design
> Principles for TPM 2.0 advises retrying sending a command or receiving
> a response using the FIFO protocol in case of any error in the protocol.
> 
> Add a retry mechanism on any protocol error. In addition, in case of a data
> integrity issue in the I2C bus protocol, check after sending a command
> completion or receiving a response from the TPM.

The first sentence of this paragraph means absolutely nothing but
nonsense. Please describe the implementation broadly instead.

Also the code is organized badly and makes the current code base a mess.
You should derive __tpm_tis_recv() from the "old" tpm_tis_recv(), and
introduce a "new" tpm_tis_recv() that calls __tpm_tis_recv() a number of
times.

/Jarkko

  reply	other threads:[~2020-06-17  1:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 13:47 [PATCH v10 0/8] Add tpm i2c ptp driver amirmizi6
2020-06-04 13:47 ` [PATCH v10 1/8] tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional amirmizi6
2020-06-17  0:37   ` Jarkko Sakkinen
2020-06-04 13:47 ` [PATCH v10 2/8] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2020-06-17  1:01   ` Jarkko Sakkinen
2020-06-17  1:05     ` Jarkko Sakkinen
2020-06-04 13:47 ` [PATCH v10 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure amirmizi6
2020-06-17  1:17   ` Jarkko Sakkinen [this message]
2020-06-04 13:47 ` [PATCH v10 4/8] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2020-06-04 13:47 ` [PATCH v10 5/8] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2020-06-04 13:47 ` [PATCH v10 6/8] tpm: tpm_tis: verify TPM_STS register is valid after locality request amirmizi6
2020-06-04 13:47 ` [PATCH v10 7/8] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2020-06-04 13:47 ` [PATCH v10 8/8] tpm: tpm_tis: add tpm_tis_i2c driver amirmizi6

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617011713.GC5100@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=Dan.Morav@nuvoton.com \
    --cc=Eyal.Cohen@nuvoton.com \
    --cc=alexander.steffen@infineon.com \
    --cc=amir.mizinski@nuvoton.com \
    --cc=amirmizi6@gmail.com \
    --cc=arnd@arndb.de \
    --cc=christophe-h.ricard@st.com \
    --cc=christophe-h.richard@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gcwilson@us.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@ziepe.ca \
    --cc=kgoldman@us.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oren.tanami@nuvoton.com \
    --cc=oshri.alkoby@nuvoton.com \
    --cc=oshrialkoby85@gmail.com \
    --cc=peterhuewe@gmx.de \
    --cc=robh+dt@kernel.org \
    --cc=shmulik.hager@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).